[vrpex] spawn error

[SnaiCrys]

It happens when you come after the crash.
Then character reset

[ImagicTheCat]

modules/survival.lua has 219 lines, so error messages are wrong or the file is modified.

[SnaiCrys]

it's my debug print and comments, sorry

155 line

AddEventHandler("vRP:playerJoin",function(user_id,source,name,last_login)
  local data = vRP.getUserDataTable(user_id)
  if data.hunger == nil then
    data.hunger = 0
    data.thirst = 0
  end
end)

[ImagicTheCat]

You can check the user_id validity and check the value of vRP.getUData(user_id, "vRP:datatable"), also check if there are MySQL errors. You can also check the vRP.setUData data in the disconnect event of base.lua.

[SnaiCrys]

I don't think I can specifically reproduce this error again. I'll add prints for the future.

[ImagicTheCat]

There are some reports of money loss, random MySQL errors, etc, so maybe using something else than vrp_mysql will solve those issues.

[SnaiCrys]

I'll try to use https://github.com/GHMatti/FiveM-MySQL

[ImagicTheCat]

You can create a driver, I don't know if this resource supports prepared statements, but stability is better than performance for now. If you create a repository, I could help you with the interface.

[SnaiCrys]

You mean the fork GHMatti''s MySQL? I have zero knowledge in C#

[ImagicTheCat]

No C#, it's just a bridge resource that depends on vrp and this resource, register a "DB driver" in Lua for vRP and use this resource API. My knowledge (and desire) about C# is poor too, it's why I added this new API to abstract any MySQL resources in vRP. It seems that this one has a Lua API, but I want to be sure that it's working well/easy to install before starting a driver.

[SnaiCrys]

https://github.com/SnaiCrys/vRP-GHMatti-s-MySQL

[ImagicTheCat]

I don't know if it's good to do it this way, I will ask on the topic of the creator.

[SnaiCrys]

In any case, we comply with AGPLv3

[ImagicTheCat]

If his work is a standalone resource, it could be better to just write the bridge and let people install his resource with our own.

[SnaiCrys]

So it would be better in terms of resource support.

[ImagicTheCat]

Yes (and no duplication of data).

[ImagicTheCat]

I think I will create a global repository with all the potential bridges inside instead, if you don't mind, easier to manage and they are too specific resources related to vRP core features, not really standalone.

[SnaiCrys]

ok, i delete mine

[ImagicTheCat]

It wasn't so difficult, I think I have GHMattiMySQL working well. https://github.com/ImagicTheCat/vRP-db-drivers

[SnaiCrys]

With a new database problem was repeated

tested without ac679a9

[vRP] 31.****193 disconnected (user_id = 41)
[vRP] Paradox (0.0.0.0) joined (user_id = 41)
[vRP] Paradox (0.0.0.0) re-joined (user_id = 41)
[vRP] Paradox (31.****.193) re-joined (user_id = 41)
[vRP] Paradox (0.0.0.0) joined (user_id = 41)
[vRP] 31.****.193 disconnected (user_id = 41)
[vRP] Paradox (31.****.193) joined (user_id = 41)

Then character reset

[SnaiCrys]

Error resuming coroutine: citizen:/scripting/lua/scheduler.lua:577: bad argument #1 to 'unpack' (table expected, got no value)
stack traceback:
	[C]: in function 'table.unpack'
	citizen:/scripting/lua/scheduler.lua:577: in function <citizen:/scripting/lua/scheduler.lua:554>
	(...tail calls...)
	base.lua:297: in field 'setUData'
	base.lua:423: in function 'task_save_datatables'

[SnaiCrys]

I don't know why this is happening, but to keep the loop going, it's better to move the SetTimeout to the beginning.

function task_save_datatables()
  SetTimeout(config.save_interval*1000, task_save_datatables) --move  this

  TriggerEvent("vRP:save")

  Debug.log("save datatables")
  for k,v in pairs(vRP.user_tables) do
    vRP.setUData(k,"vRP:datatable",json.encode(v)) -- v==null?
  end
end

[SnaiCrys]

When a lot of players try to connect to a full server, they are stored in a strange way in the DB and die when spawned (because there is no value for hp). Note even that there is no user group
{inventory":{"item":{"amount":5}},"thirst":0,"groups":[],"hunger":0}

[ImagicTheCat]

Probably irrelevant for vRP 2.