Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to choose between MSGPack and JSON #512

Closed
tabarra opened this issue Apr 7, 2019 · 3 comments
Closed

[Feature Request] Option to choose between MSGPack and JSON #512

tabarra opened this issue Apr 7, 2019 · 3 comments

Comments

@tabarra
Copy link
Contributor

tabarra commented Apr 7, 2019

It would be good too have the option to use JSON instead of MSGPack.
Related to this commit: 6dabc56

@ImagicTheCat
Copy link
Member

Complicated to do, because it's not only about JSON, but about binary data VS human readable data I suppose. What's wrong with MessagePack ?

@tabarra
Copy link
Contributor Author

tabarra commented Apr 7, 2019

For a simple test I swapped all msgpack functions for json and apparently it worked properly.
But considering that I just now started with FiveM/vRP, I'm not so sure if I cold tell if everything is working properly or not.

@ImagicTheCat
Copy link
Member

MessagePack is superior for binary non-human readable storage, so if you want JSON I suppose it's for modifying the structure by editing text, so you need to change the way it is stored by the SQL engine. I'm against that, if you need to read/edit the data from the DB, you can use MessagePack from your favorite language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants