Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated func #421

Closed
wants to merge 2 commits into from
Closed

Conversation

SnaiCrys
Copy link
Contributor

@SnaiCrys SnaiCrys commented Apr 25, 2018

@SnaiCrys SnaiCrys changed the title fix deprecated func https://github.com/ImagicTheCat/vRP/issues/399 fix deprecated func Apr 25, 2018
@ImagicTheCat
Copy link
Member

ImagicTheCat commented Apr 25, 2018

The deprecated errors are not really errors, the call should not be modified because smoothing was not my intent in the first place.
What about the panner/listener coords stuff ? Is that standard ? I don't find anything about it.

Also, I don't understand this one: d6984f4

@SnaiCrys
Copy link
Contributor Author

value is no longer used in AudioParam, everywhere it should be replaced with setTargetAtTime or setValueAtTime. Example: https://github.com/goldfire/howler.js/blob/master/src/plugins/howler.spatial.js

in d6984f4 I forgot to change the coordinate axes and fixed it

@ImagicTheCat
Copy link
Member

Smoothing is deprecated, it doesn't seem that the value parameter is. Also:
What about the panner/listener coords stuff ? Is that standard ? I don't find anything about it.

@SnaiCrys
Copy link
Contributor Author

@SnaiCrys SnaiCrys deleted the patch-25/04 branch May 2, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants