New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalization of collection names should be consistent with TCIA conventions in all places #414
Comments
George says it's just formatting, will be fixed to use upper case, consistent with the TCIA conventions. |
@ulrikew indeed, so you recommend we use those names? As @bcli4d identified and documented, there are differences in spelling between the various ways those names can be obtained, between TCIA_API_CollectionID, NBIA_CollectionID and TCIA_Webapp_CollectionID. As a preview, see below, but I can also make a complete list. As you can see, it is not as trivial as using '_' in place of ' '. Is it a bug or something that need to be addressed on the TCIA/NBIA side to make sure the names are consistent across the various ways those names can be obtained? |
@G-White-ISB @s-paquette can we switch to using As you can see from the summary here: https://docs.google.com/spreadsheets/d/1CZTY8SkPM4mJlSihx-NQ4lZqD5begW67JxpkUjHIyyI/edit?usp=sharing, it's not a simple transformation from |
TCIA collection names (https://www.cancerimagingarchive.net/collections/) should now appear consistently in IDC |
We have similar issues in NBIA and have brought this up as a topic in this morning's NBIA/TCIA call. Our plan is to work towards a size limit for the collection short names. Which max length would IDC prefer? |
I am not sure it is a good idea to change the collection names for the existing collections, so I think we need to have a way to deal with the current lengths. Did you think about enacting the limit going forward, or also for the existing collections, Ulli? |
@fedorov I do not yet know the answer to your question. I will put it on the IRCoCo agenda for all to discuss. |
Old issue but worth checking again? I think we are now consistent |
Yes, looks good. Only (very minor) difference I found was the last letter in the MIDRC collection names. Don't fix. |
Currently, it is lower-case in the right panel.
The text was updated successfully, but these errors were encountered: