Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object Class Display on Hover #195

Open
pedrokohler opened this issue Apr 2, 2024 · 13 comments
Open

Implement Object Class Display on Hover #195

pedrokohler opened this issue Apr 2, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@pedrokohler
Copy link
Collaborator

pedrokohler commented Apr 2, 2024

it would be great to have the option of hovering over an object and having the class or a class nickname displayed.

show ROI number/details in a tooltip as an option on mouse-over

Implement Object Class Display on Hover

Description

Implement a feature that allows users to hover over an object and display its class or a class nickname. This enhancement will provide users with quick access to important information about objects, improving usability and workflow efficiency.

Acceptance Criteria

  1. When hovering over an object, its class or class nickname should be displayed.
  2. The displayed class information should be easily readable and unobtrusive.
  3. Ensure that the class display feature is responsive and activates promptly upon hovering.
  4. The class display should seamlessly integrate with existing object interaction functionalities.

The viewer currently displays Region of Interest (ROI) number and details in a tooltip upon mouse-click. This feature requires retesting to ensure its functionality extends to all annotations.

From #184

@pedrokohler pedrokohler added the enhancement New feature or request label Apr 2, 2024
@pedrokohler pedrokohler self-assigned this Apr 2, 2024
@pedrokohler pedrokohler added this to To do in IDC Apr 2, 2024
@pedrokohler
Copy link
Collaborator Author

@fedorov

So we'll show the ROI number and the class nickname. Do we need anything else?

@igoroctaviano igoroctaviano changed the title Tooltip for annotations Implement Object Class Display on Hover Apr 11, 2024
@fedorov
Copy link
Member

fedorov commented May 8, 2024

Nothing is shown on mouse click when Slim is deployed in view-only mode (as it is in IDC).

I suggest we should include in the tooltip the same information that is currently shown for that annotation in the right-hand slide panel. What do you think?

@fedorov fedorov moved this from To do to In progress in IDC May 9, 2024
@fedorov
Copy link
Member

fedorov commented May 9, 2024

Let's change the deploy configuration for the test instance to be "read only" so we test this feature in the same way as it would appear in IDC deployment. Let's just do the double-click/click for now, and after testing that discuss if we still want to have hover support.

@igoroctaviano
Copy link
Collaborator

@fedorov I updated the env https://slim-dmv.web.app/
Now it should be read-only similar to IDC's slim deployment.
You can double check the annotation groups or the ROIs and it should open the dialog.
After the test let us know if we are going to add the hover tooltip or stick with the double click dialog.

@fedorov
Copy link
Member

fedorov commented May 17, 2024

You can double check the annotation groups or the ROIs and it should open the dialog.

It does - thank you!

@pedrokohler
Copy link
Collaborator Author

You can double check the annotation groups or the ROIs and it should open the dialog.
It does - thank you!

@fedorov does this mean that there is no reason to keep this issue open, or should something be developed?

@fedorov
Copy link
Member

fedorov commented Jun 10, 2024

I reviewed what is available right now.

I think there is a bug or I don't understand something, but I do not think it makes sense to have 3 states for the annotation highlights (yellow, bright blue and pale blue). Is this a bug?

2024-06-10_12-13-33

Second, I think showing ROI information on hover would be very helpful, so let's keep this ticket open.

@igoroctaviano
Copy link
Collaborator

I reviewed what is available right now.

I think there is a bug or I don't understand something, but I do not think it makes sense to have 3 states for the annotation highlights (yellow, bright blue and pale blue). Is this a bug?

2024-06-10_12-13-33 2024-06-10_12-13-33

Second, I think showing ROI information on hover would be very helpful, so let's keep this ticket open.

@fedorov Do you think this bug was caused by this change, or is it an unrelated/new issue found in Slim?

@fedorov
Copy link
Member

fedorov commented Jun 10, 2024

I do not know. Click to show ROI information was not enabled in the past, so I do not have experience using it. We don't have it enabled in the IDC deployment either.

@igoroctaviano
Copy link
Collaborator

I do not know. Click to show ROI information was not enabled in the past, so I do not have experience using it. We don't have it enabled in the IDC deployment either.

Could you please share the env, and server used so @pedrokohler or myself can replicate this issue?

@igoroctaviano
Copy link
Collaborator

This is the DICOM store: https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb.

I was testing with your https://slim-dmv.web.app/ instance.

@pedrokohler please replicate this issue locally using the master branch. If it's reproducible using master then create a new issue for it and attach the video shared by Andrey. I guess that we have two highlighting here which are only noticeable when testing against SR annotations (one highlight from OpenLayers and another from slim).

@fedorov
Copy link
Member

fedorov commented Jun 11, 2024

I just noticed this today - maybe this is related, see demo below. I was not aware of this functionality earlier.

2024-06-11_18-04-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
IDC
In progress
Development

No branches or pull requests

3 participants