Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using contributions as votes for milestones #266

Open
4 tasks
f-gate opened this issue Nov 7, 2023 · 0 comments
Open
4 tasks

Stop using contributions as votes for milestones #266

f-gate opened this issue Nov 7, 2023 · 0 comments

Comments

@f-gate
Copy link
Member

f-gate commented Nov 7, 2023

it just does make sense anymore with the introduction of grants, where an approver is a contributor yet hasnt contributed.
The state should make sense, it currently doesnt.

What is needed to change?

  • Add approvers which are the accounts responsible for approving milestones. We must also have a vote_weight (the same as before).

  • Remove the concept of 'contributor'. In fact this is not needed at all due to the introduction of multi chain refund_locations in the config.

  • In pallet grants, then we can say that we have 'approvers' not contributors and just specify the TreasuryOrigin on instantiation to handle refunds.

  • Alas in vote_on_milestone refactor the terminology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant