-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict c++17 now compiles #13
Conversation
… for vertices (they check correctly now). Paq.sh now automatically outputs to nuklear.h.
Continuing discussion from #11: Why is it needed to introduce yet another define? Couldn't we use |
Because the moment that ifdef is used, it is immediately defined. |
I mean, c89 supports |
Does it? C++17 gave me an error on that. |
Right, |
And because it changes |
Okay, I'll get on it when I got time again |
Fixed. @dumblob |
One last little piece - the version info has to be updated also in https://github.com/Immediate-Mode-UI/Nuklear/blob/master/src/CHANGELOG 😉 (and |
Done. |
Merged with the latest PR and updated so it works with strict clang c++17 too. |
I'm sorry, didn't notice it before, but could you make Thanks again for your effort! |
Fixed @dumblob, python used 'print' which prints newline characters based on the current platform. I set it to force linux line endings. |
LGTM. Maybe just squash the commits into one, to keep the git history tidy :) |
Fixes issue #11
Now detecting if memcpy and memset are actually needed. And same goes for the vertex check (they check correctly now).
Paq.sh now automatically outputs to nuklear.h.