Backend: SDL2 SDL_Renderer

[1bsyl]

Provide an example to build Nuklear using SDL2 / SDL_RenderGeometry (using this PR libsdl-org/SDL#4195)

Which makes Nuklear using the platform backend available (opengl, opengles2, Direct3D11, Metal, or software rendering).

[gabrielrad]

@1bsyl just a small curiosity..is this is meant to be working with the SDL_Renderer, why the need to specify those OpenGL attributes? Is there any limitation? I'm asking this because I use SDL and don't want to drop D3D11 :)

[1bsyl]

@gabrielrad
Sorry I forgot to remove them ! After I copy pasted the opengl example...
(though you may want maybe want to add some GL attribute if you use and want to configure the opengl backend specifically)

I'll clean up this example if the SDL branch is merged. (so please don't merge the branch right now).

This example should also run on with D3D11 / METAL / opengl / gles2 / and software.
Not running with native SDLdirect3d ( 9 ? ), because I haven't add the triangles function in it.
It also runs with the software renderer backend

[gabrielrad]

Thank you for being awesome @1bsyl ! Fingers crossed it gets merged in SDL2! I'm very happy on using SDL2 for everything especially the drawing aspect, and having also the ability to use something like dear imgui alongside would be a dream come true!

[gabrielrad]

@1bsyl undefined reference for SDL_RenderGeometryRaw

[1bsyl]

@gabrielrad
I haven't pushed everything into the SDL branch, but I've planned to do this today

[1bsyl]

@gabrielrad I have pushed so stuff to SDL branch (not yet the METAL nor the D3D11 implementation)

[1bsyl]

@gabrielrad : I've pushed METAL and D3D11 backend updates

[atticus5]

@1bsyl In nk_sdl_render you should reset the clip rectangle back to default with SDL_RenderSetClipRect(sdl.renderer, NULL); otherwise it might mess with the drawing logic other people have..

Also did you figure out how to draw textures?

[1bsyl]

@gavriil07
added save&restore the clip rect.
About texture: the SDL api draws textures.
Not sure about Nuklear, I'm not familiar with it.

[atticus5]

@1bsyl Not quite right..You should check SDL_RenderIsClipEnabled before saving the clip rectangle, because if clipping is disabled you don't want to activate it with an empty rectangle :

rect	an SDL_Rect structure filled in with the current clipping area or an empty rectangle if clipping is disabled

(https://wiki.libsdl.org/SDL_RenderGetClipRect)

This seems to work nice:
SDL_Rect *saved_clip = NULL; if (SDL_RenderIsClipEnabled(sdl.renderer)) SDL_RenderGetClipRect(sdl.renderer, saved_clip);

I know SDL has support for drawing textures, that is why it would be nice that your example would include some image buttons also, because nuklear supports this. I for myself could not get it working..

[1bsyl]

@gavriil07 yes you're right you need to check if clipping was enabled
but you're example is wrong. you've no storage for saved_clip, only null ptr.

Sorry I don't know the Nuklear API, I modified the existing example to test SDL_RenderGeometry.
But for sure it works with texture. It actually use the g_fonttexture.

[1bsyl]

I don't really understand this stack-trace. If you think there is a bug with RenderGeometry, you can as well write a small SDL test-case

…

On Sun, 4 Apr 2021 at 18:21, gavriil07 ***@***.***> wrote: @1bsyl <https://github.com/1bsyl> I think I might have caught a bug. This causes a segmentation fault: SDL_Texture *Texture = GetTextureData(E_ICON_BOX); if (Texture) { struct nk_image Image = nk_image_handle(nk_handle_ptr(Texture)); nk_image(ctx, Image); nk_button_image(ctx, Image); } The root of the problem(taken from CLion GDB): SDL_RenderGeometryRaw_REAL SDL_render.c:3638 nk_sdl_render nuklear_sdl_sdlrenderer.h:133 EndDrawing draw.c:98 Draw ssssss.c:165 UpdateAndRenderPlay ssssss.c:146 RunGame sssss.c:87 SDL_main main.c:22 main_getcmdline SDL_windows_main.c:69 __tmainCRTStartup 0x00000001400013c1 WinMainCRTStartup 0x00000001400014d6 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGH4KEWBVVFKVDJRXDZLL3THCGYHANCNFSM4Z26AJAQ> .

-- Sylvain Becker

[jwurzer]

SDL 2.0.18 was released on 30. Nov 2021 with official Support for SDL_RenderGeometry() and SDL_RenderGeometryRaw() :-)
Is there any stopper with this pull request to support Nuklear with SDL renderer? I think it would be great if Nuklear official include this pull request to support a demo with SDL renderer.

[RobLoach]

Mind adding the Canvas demo too?

[RobLoach]

SHould this be #include <SDL2/SDL.h> instead?

[RobLoach]

Incorrect header define.

[RobLoach]

#include <SDL2/SDL.h>?

[RobLoach]

Incorrect define.

[RobLoach]

Brought over to #396 ... Thanks so much!