This repository has been archived by the owner on Jan 11, 2020. It is now read-only.
Floating windows choose where they display #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnirkImmington
approved these changes
Jan 17, 2017
| @@ -360,7 +367,7 @@ pub extern fn pointer_motion(view: WlcView, _time: u32, point: &Point) -> bool { | |||
| if let Ok(mut tree) = try_lock_tree() { | |||
| // TODO Change to id of _view | |||
| // Need to implement a map of view to uuid first though... | |||
There was a problem hiding this comment.
Nit: comments are out of date
| /// Updates the geometry of the view from an external request | ||
| /// (such a request can come from the view itself) | ||
| /// | ||
| /// This is only applied to the view if it is floating. |
There was a problem hiding this comment.
Nit: another old comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result<&/&mut Container, TreeErrorfor better error checking.Doesn't totally fix #218, as we don't do any centering. Still considering whether that's worth implementing.