Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing private entries #182

Open
2 tasks
dandavies99 opened this issue Oct 12, 2022 · 0 comments
Open
2 tasks

Sharing private entries #182

dandavies99 opened this issue Oct 12, 2022 · 0 comments
Labels
backend related to the backend enhancement New feature or request frontend related to the frontend permissions to do with roles, permissions, guardian etc.

Comments

@dandavies99
Copy link
Collaborator

dandavies99 commented Oct 12, 2022

Problem
The current permissions setup is a bit simplistic - simply having private and public entries. It is quite common for users to want to share entries (e.g. experiments) with a specific set of other users, especially while the work is ongoing.

Proposed solution

  • Allow users to select other users who can also have read access to private entries they have created.
  • In practice, this could be done with a "read_users" field which is updated by the owner.
  • Upon saving, in the existing (or possibly a new) post-save signal the read permissions should be granted to those users for that object.
  • Importantly, permissions should also be taken away from users who are not in the list (as users could be removed from the list by the owner).

Potential blockers

  • Would need to check carefully how the read permission is applied in different situations e.g. when the read_only users are in different groups which already have a certain permission set for the object in question.
  • This would mainly be applicable to experiments but would also need to be implemented for device specifications and batches of those devices.

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-138-3

@dandavies99 dandavies99 removed the question for researchers Further information is requested from domain experts label Dec 8, 2022
@dandavies99 dandavies99 added this to the Milestone 2a milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend related to the backend enhancement New feature or request frontend related to the frontend permissions to do with roles, permissions, guardian etc.
Projects
None yet
Development

No branches or pull requests

1 participant