Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R should not be inferred during seeding period #54

Open
ChrisHIV opened this issue Nov 9, 2020 · 3 comments
Open

R should not be inferred during seeding period #54

ChrisHIV opened this issue Nov 9, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ChrisHIV
Copy link

ChrisHIV commented Nov 9, 2020

R should not be inferred during seeding period, because infections then are modelled as iid from an exponential each day, not arising from a renewal process. My plot_rt() output shows me that it is being inferred during that period, and indeed the posterior is changing during that period.

@jscott6
Copy link
Collaborator

jscott6 commented Nov 10, 2020

What you see from plot_rt() is the R simulated from the posterior. Somewhat confusingly, even though only seeding is occuring during the first few days of the epidemic (and when R is not used), the plot shows the posterior predictive for R during this initial period. Rest assured however that the R here does not appear in the likelihood, so the inferences are unaffected by this issue.

Perhaps for clarity we should change the interface so that seeding is taken to occur prior to the first date found in 'data'? @agandy @s-mishra

@jscott6 jscott6 added the enhancement New feature or request label Nov 10, 2020
@ChrisHIV
Copy link
Author

Gotcha.
Arguably the user might want either - to provide data that they think begins with a seeding phase (e.g. observed imported cases) or begins after it.

@ChrisHIV
Copy link
Author

I do think it would be clearer to not plot R during the seeding period, because the user and the model are saying that cases during this period are not arising from a renewal process, so R at this point is undefined. And plotting a posterior for R that's different from 1 here, while plot_infections() shows constant incidence here, seems like a contradiction. Could simply truncate the x axis for plot_rt() (but not plot_infections(), as seeing the constant incidence clarifies the role of the seeding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants