Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast color changing bans host for hacking. #286

Closed
1 task done
AerGameChannel opened this issue Jan 10, 2021 · 4 comments · Fixed by #327
Closed
1 task done

Fast color changing bans host for hacking. #286

AerGameChannel opened this issue Jan 10, 2021 · 4 comments · Fixed by #327

Comments

@AerGameChannel
Copy link

AerGameChannel commented Jan 10, 2021

Bug Report

Base Information

  • Windows 10
  • Impostor-Server_1.2.2-ci.124_win-x64
  • Modded 12.9s (Works without mods too)

I confirm:

  • that I have searched for an existing bug report for this issue.

Symptoms

When there are 2 players in lobby and non-host player starts to change colors very fast, host gets banned for "You were banned for hacking. Please stop" This is output from console:

[16:59:39 INF] MWBMQM - Player not Aer (14) has left.
[16:59:39 INF] MWBMQM - Assigned not Aer (16) as new host.
[16:59:39 INF] Client 14 disconnecting, reason: Client sent SetColor with incorrect color

Reproduction

  1. Start a server
  2. Create a room
  3. Join this room from second client
  4. Start changing colors very fast on non-host client
    image
@AerGameChannel
Copy link
Author

Also the bug works when there are more than 2 players.

@AerGameChannel
Copy link
Author

Closing this issue because js6pak and Elsensee made a PRs that will probably fix this bug, ty guys.

@tsufunk2005
Copy link

Nothing in this thread helped. It still bans you. Where is the fix?

@JohnTranQUT
Copy link
Contributor

JohnTranQUT commented Feb 1, 2021

I believe I am having the same issues too. Since my fork involved merging with a lot of other existing pulls, I've chose not to raise an issue (in case other things was causing it).
Hopefully this problem gets fixed soon. The recent patch/fix @js6pak did alleviate the issue but didn't resolve it completely for me.
Wasn't great for my private server, since I need players to remain connected and so instead I've disabled some exceptions thrown. They were: CheckName, CheckColor, SetName, SetHat, SetPet and SetSkin inside src\Impostor.Server\Net\Inner\Objects\InnerPlayerControl.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants