Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new editor CKEditor as option #570

Closed
fiammybe opened this issue Dec 11, 2019 · 9 comments
Closed

Include new editor CKEditor as option #570

fiammybe opened this issue Dec 11, 2019 · 9 comments
Assignees
Milestone

Comments

@fiammybe
Copy link
Member

Describe the bug

The current default editor is the old and rusty HTML editor. Other options are FCK editor, which is ancient as well. Upgrade this please!

To Reproduce

Create content

Expected behavior

The base editor is the CKEditor

@fiammybe fiammybe modified the milestones: 1.4.0, 1.4.1 Dec 11, 2019
@fiammybe fiammybe changed the title 1.4.0 RC - make the default editor CKEditor Make the default editor CKEditor Dec 11, 2019
@fiammybe
Copy link
Member Author

this is beyond the scope of 1.4.0, but would be a good fit for both 1.4.1 and 2.0.
There is a working CKEditor 4.5.3 editor around, but it needs some updates to make it more generic.

@MekDrop
Copy link
Member

MekDrop commented Dec 12, 2019

For 2.0 once possible (when we I will able to figure out what todo with assets - #134) I plan to add summernote or any other similar editor as default. It's lightweight but also extensible.

@fiammybe
Copy link
Member Author

Great find! At the moment all our editors are based on the fact that they extend a htmltextarea. Summernote is more flexible, it uses a div with a specific ID that you can choose yourself.
We'll need to take this into account on the editor side before we can start writing integrations with this kind of editors.

But overall 👍

@skenow
Copy link
Contributor

skenow commented Dec 14, 2019

The limitation on how to insert into the page is not the editor, but the decision to support the legacy editor and allow replacement with another editor of choice., without having to resort to a lot of hacks when switching - the same elements are used for all editors.

CKEditor 5 is still quite viable. Our role is to build the hooks and allow freedoms to choose any modern editor.

@skenow
Copy link
Contributor

skenow commented Dec 14, 2019

This comparison is quite thorough - compatibility with the 'new' IE (Edge, may it be as good as IE6 ;-) )

@fiammybe
Copy link
Member Author

fiammybe commented Mar 1, 2020

Nice comparison, and I see CKeditor 5 comes up last :-( However I think including CKEditor 4 or 5 in the core now, without forcing anyone to switch at the moment, will give the choice for those that want to use newer editors, and keep us from having to write an automated conversion for the moment.
Forcing is not a good way, not until a reasonable migration period is communicated first.

@fiammybe fiammybe added this to To do in ImpressCMS v1.x Mar 5, 2020
@fiammybe fiammybe changed the title Make the default editor CKEditor Include new editor CKEditor as option Mar 5, 2020
@fiammybe fiammybe modified the milestones: 1.4.1, 1.4.2 Apr 10, 2020
@skenow
Copy link
Contributor

skenow commented Jul 16, 2020

There is a repository for CKeditor as an editor for ImpressCMS - https://github.com/skenow/impresscms-ckeditor.git

I have it working on some production sites.

@fiammybe fiammybe modified the milestones: 1.4.2, 1.4.3 Dec 21, 2020
@fiammybe fiammybe modified the milestones: 1.4.3, 1.4.4 Mar 21, 2021
@github-actions
Copy link

This issue was automatically marked as stale

@github-actions github-actions bot added the stale label May 28, 2021
@fiammybe fiammybe modified the milestones: 1.4.4, 1.4.3 Feb 19, 2022
@fiammybe fiammybe removed the stale label Feb 19, 2022
@fiammybe
Copy link
Member Author

This was included in the 1.4.3 release

ImpressCMS v1.x automation moved this from To do to Done Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants