Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration validation option #149

Closed
dspruell-i01 opened this issue May 5, 2023 · 2 comments · Fixed by #150 or #151
Closed

Add configuration validation option #149

dspruell-i01 opened this issue May 5, 2023 · 2 comments · Fixed by #150 or #151
Assignees
Labels
enhancement New feature or general improvement threat-intel Issue originated from Threat Intel (TI) team

Comments

@dspruell-i01
Copy link

To enable better automation & confidence in configuration changes prior to reloading the tool, implement a configuration validation option similar to many other software.

The use case is to support a workflow:

  1. Make changes to the program configuration.
  2. Run configuration validation, ensuring that the configuration can be loaded correctly.
  3. Reload or restart running service.

This workflow can also support automation for configuration management, e.g. using Ansible to deploy and validate an updated configuration before restarting the service.

Scope of validation:

  • YAML config is valid/no syntax issues
  • Basic ThreatIngestor config is viable, no missing required options or conflicting parameters, etc.
@dspruell-i01 dspruell-i01 added the enhancement New feature or general improvement label May 5, 2023
@dspruell-i01 dspruell-i01 added the threat-intel Issue originated from Threat Intel (TI) team label May 31, 2023
@battleoverflow battleoverflow self-assigned this Jun 5, 2023
@battleoverflow battleoverflow linked a pull request Jun 5, 2023 that will close this issue
@battleoverflow
Copy link
Contributor

Hi @dspruell-i01,

I believe this issue is now resolved under PR #150. Do you have any issues with closing?

@battleoverflow battleoverflow mentioned this issue Jun 7, 2023
@battleoverflow battleoverflow linked a pull request Jun 7, 2023 that will close this issue
@dspruell-i01
Copy link
Author

I think we're good! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or general improvement threat-intel Issue originated from Threat Intel (TI) team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants