Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sqlite for saved_state #44

Closed
rshipp opened this issue Jan 17, 2019 · 1 comment
Closed

Use sqlite for saved_state #44

rshipp opened this issue Jan 17, 2019 · 1 comment
Labels
enhancement New feature or general improvement
Projects
Milestone

Comments

@rshipp
Copy link
Contributor

rshipp commented Jan 17, 2019

Writing the config every time we update the state is messy. With #39, this becomes even worse, since when we write out the config from the internal dict, it's not guaranteed to be in the same order we read it in.

As a cleaner implementation, change to reading/writing config from a sqlite database instead.

Basic design proposal:

  • Config support for a new general variable, state_file, relative or absolute path to sqlite db.
  • State class with get(name) and save(name).
  • SQLite db with a table with name, state columns.
@rshipp rshipp added the enhancement New feature or general improvement label Jan 17, 2019
@rshipp rshipp added this to Future Milestones in Issues via automation Jan 17, 2019
@rshipp rshipp added this to the 1.0.0 milestone Jan 17, 2019
@rshipp rshipp moved this from Future Milestones to To do in Issues Jan 17, 2019
@rshipp rshipp moved this from To do to In progress in Issues Jan 18, 2019
@rshipp rshipp moved this from In progress to Done in Issues Jan 22, 2019
@rshipp
Copy link
Contributor Author

rshipp commented Jan 22, 2019

Closed by #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or general improvement
Projects
No open projects
Issues
  
Done
Development

No branches or pull requests

1 participant