Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Package manifest for Swift 5.3 to resolve the Xcode 12 warning #88

Merged

Conversation

asolovev
Copy link
Contributor

Adding this library into Swift Package Manager using Xcode 12 generates a following warning
"The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99."
There are a couple solutions to this that I know:

  1. Deployment target can be increased to .iOS(.v9) in the main Package.swift file.

  2. A separate Package manifest can be created to target a specific swift version.

I went the second way to make changes smaller.

@InderKumarRathore
Copy link
Owner

Thanks for taking time to raise the pull request. I was thinking not to support iOS 8 as cocoapods was also throwing me warning. Would prefer to remove the support for iOS 8, instead of maintaining a new file. Also I checked the supported device for iOS 8 and iOS 9, both are same (supporting from iPhone 4s).

@asolovev
Copy link
Contributor Author

Sounds good as well. Do you want me to update this PR to be a small change in the original Package.swift? It should resolve this warning with SwiftPM without requiring any adjustments for other dependency managers for now.

@InderKumarRathore
Copy link
Owner

Up to you. If you don't I'll do it tomorrow

@asolovev
Copy link
Contributor Author

asolovev commented Nov 20, 2020

Thank you. I have updated this PR to change the main Package.swift as you suggested. If you will do a bigger PR soon, you can skip this one and apply this change yourself along with others. It is a one-liner anyway :)

@InderKumarRathore InderKumarRathore merged commit 674c817 into InderKumarRathore:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants