Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bundle version when using Carthage #89

Closed
minixT opened this issue Nov 19, 2020 · 5 comments
Closed

Missing bundle version when using Carthage #89

minixT opened this issue Nov 19, 2020 · 5 comments

Comments

@minixT
Copy link

minixT commented Nov 19, 2020

Hi,
I was trying to upload an app to AppStore Connect with DeviceGuru framework built using Carthage and I received this error:

This bundle Payload/xxx.app/Frameworks/DeviceGuru.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

I checked Info.plist in the framework and version was actually missing. I checked also DeviceGuru project and it looks like bundle version is set to $(CURRENT_PROJECT_VERSION) but this option is empty in build settings.

Can you fix this by adding some value to CURRENT_PROJECT_VERSION option in build setting, so I can successfully upload my app.

Thanks

@InderKumarRathore
Copy link
Owner

I added the bundle version 7.0.1 same as pod version. I hope this should work

@minixT
Copy link
Author

minixT commented Nov 20, 2020

@InderKumarRathore, it looks like it didn't help. I tested this and updating this value only in info.plist is not enough. Only after setting CURRENT_PROJECT_VERSION option in build settings I was able to receive framework with CFBundleVersion.

@InderKumarRathore
Copy link
Owner

Can you please raise a PR?

@InderKumarRathore
Copy link
Owner

fixed

@minixT
Copy link
Author

minixT commented Nov 23, 2020

Now it works. Thank you!

@minixT minixT closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants