Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feasibility of targeting finch with this codebase? #1

Open
hderms opened this issue Sep 4, 2019 · 1 comment
Open

Feasibility of targeting finch with this codebase? #1

hderms opened this issue Sep 4, 2019 · 1 comment

Comments

@hderms
Copy link

hderms commented Sep 4, 2019

Curious if you've given thought to what would be required to make this work with finch as well as https

@IndiscriminateCoding
Copy link
Owner

IndiscriminateCoding commented Sep 4, 2019

It's definitely feasible.

Some thoughts off the top of my head:

  1. Code that generates JSON models can be reused as is
  2. Most tricky part would be content-type handling. It's better to avoid large coproduct types, so one approach here is to group Endpoints by content-type with Endpoint.coproduct and then compose such groups with Endpoint.:+:
  3. Handling request parameters would be much simpler than in http4s. Especially multipart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants