Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pgscan to support npm lockfileversion 3 #34

Closed
ShaydeNofziger opened this issue Jul 27, 2023 · 2 comments
Closed

Update pgscan to support npm lockfileversion 3 #34

ShaydeNofziger opened this issue Jul 27, 2023 · 2 comments

Comments

@ShaydeNofziger
Copy link
Contributor

Currently, pgscan only appears to work with lockfileversion=2 package-lock.json npm files. I believe this is because syntax was changed with lockfileversion 3 and the "dependencies" node is no longer where it was in lockfileversion 2.

Can anyone else confirm this issue, and would you be open to a PR to fix this?

@whatatripp
Copy link
Member

We would love some help would be very grateful for a pull request :)

It seems easy enough to fix, but the "hard part" for us is getting this tested/verified. We don't have a "problem project" ourselves yet, so we have to repro, study, fix, test, etc.

Also, this is currently in discussion here, so I'll close this Issue:
https://forums.inedo.com/topic/3877/pgscan-lockfileversion-3-for-npm-dependencies-not-supported

hopefully you can reply on the forums; unlike our forums, we don't have an internal tracker for GitHub issues, so it's too easy for us to lose track of open discussions

@ShaydeNofziger
Copy link
Contributor Author

@crotondo-dap before I spend an afternoon attempting to fix this, are you looking at a fix for this already? If not I'm going to go ahead with a PR. I'll follow up in the forums as well but don't currently have an account there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants