Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to specify time units when setting up "horizon" #70

Closed
kjsato opened this issue Nov 9, 2023 · 5 comments
Closed

how to specify time units when setting up "horizon" #70

kjsato opened this issue Nov 9, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@kjsato
Copy link
Contributor

kjsato commented Nov 9, 2023

in 5.3 Setting up the "horizon":

  • The horizon refers to the difference between the target_date and the origin_date in time units specified by the hub (these could be days, weeks, or months).

Is it necessary to add an explanation of how to specify the time unit when specifying the horizon?

@mzorn-58
Copy link
Contributor

mzorn-58 commented Apr 1, 2024

Does it make sense to add the following after the first bullet point [n 5.3](The horizon refers to the difference between the target_date and the origin_date in time units specified by the hub (these could be days, weeks, or months).) And is the following comment correct?

Time units can be specified when defining "target_metadata". See Step 7.

@LucieContamin
Copy link
Contributor

It sounds good to me, thanks! I guess we should also add example for a target_date/target_end_date column.

@LucieContamin LucieContamin self-assigned this Apr 1, 2024
@nickreich
Copy link
Contributor

@LucieContamin are you actively working on this, or can/should we assign someone else who works on documentation?

@LucieContamin
Copy link
Contributor

I apologize, I forgot I assigned myself. Someone else can work on it, I will not have the time in the next week, sorry about that

@LucieContamin LucieContamin removed their assignment May 17, 2024
@nickreich nickreich added the documentation Improvements or additions to documentation label May 17, 2024
@mzorn-58 mzorn-58 self-assigned this Jun 5, 2024
@mzorn-58 mzorn-58 mentioned this issue Jun 5, 2024
@mzorn-58
Copy link
Contributor

mzorn-58 commented Jun 5, 2024

@LucieContamin and I consider issue closed

@mzorn-58 mzorn-58 closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

4 participants