Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwise to change key number on failure #4

Open
joseluu opened this issue Feb 23, 2021 · 0 comments
Open

Unwise to change key number on failure #4

joseluu opened this issue Feb 23, 2021 · 0 comments

Comments

@joseluu
Copy link

joseluu commented Feb 23, 2021

In file NfcUtils.java around line 79, the software allocates a new key in case of failure when using the currently selected key.

This does not fit with the current user interface, as the newKeyIndex is not shown nor reflected by the user's choice from the UI.
So if the card reader, misreads or mistransmits the APDU or if the user gesture with the card is too fast, then another key is used, another address is shown at the user interface without the ability to know it and reach it for subsequent transactions.

I removed the if (e.getSw1Sw2() == SW_KEY_WITH_IDX_NOT_AVAILABLE) { ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant