Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad thumb path #19

Closed
JILeXanDR opened this issue Oct 5, 2018 · 6 comments
Closed

Bad thumb path #19

JILeXanDR opened this issue Oct 5, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@JILeXanDR
Copy link
Contributor

JILeXanDR commented Oct 5, 2018

Should add documentation for this config https://github.com/InfinetyES/Nova-Filemanager/blob/e0c8bb7745422bcf837769ce92ede45c4e6226a4/src/Http/Services/GetFiles.php#L374-L381
because it returns false and makes bad link

@Krato
Copy link
Collaborator

Krato commented Oct 7, 2018

Thanks @JILeXanDR. Let me check it. Regards!

@Krato
Copy link
Collaborator

Krato commented Oct 9, 2018

@JILeXanDR Changed in the last release. This config is not used anymore.

@Krato Krato closed this as completed Oct 9, 2018
@JILeXanDR
Copy link
Contributor Author

@Krato The bug is remained =(

I have disk called img:

// filesystems.php
'img' => [
    'driver' => 'local',
    'root' => public_path('assets/img'),
    'url' => env('ADMIN_URL') . '/assets/img',
    'visibility' => 'public',
],
// .env
FILEMANAGER_DISK=img

The full link should be http://admin.host.local/assets/img/avatars/1.jpg
but ajax /data?folder=avatars generates another with storage:
http://admin.host.local/storage/1.jpg

The problem is in https://github.com/InfinetyES/Nova-Filemanager/blob/856b24dc5d512d0a22b9bbedc3d37a6d51ac1183/src/Http/Services/GetFiles.php#L215-L221

@Krato
Copy link
Collaborator

Krato commented Oct 15, 2018

Ok. I will take a look. Thanks

@Krato Krato reopened this Oct 15, 2018
@Krato Krato added the bug Something isn't working label Dec 10, 2018
@ianmcqueen
Copy link

ianmcqueen commented Dec 13, 2018

@Krato I am also experiencing this bug (broken thumbnail) for the following file system configuration:

// config/filesystems.php
'uploads' => [
    'driver' => 'local',
    'root' => public_path('uploads'),
    'url' => env('APP_URL').'/uploads',
    'visibility' => 'public',
],

The thumbnail URL is displaying as style="background-image: url("/storage/ffq-newquest.jpg");" when it should be using url from the file system configuration (uploads).

Thanks for this great plugin!

@Krato
Copy link
Collaborator

Krato commented Mar 11, 2019

Hello @JILeXanDR and @ianmcqueen. Please, update to v2. Should be fixed. Regards.

@Krato Krato closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants