Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility with bunch library #9

Closed
wants to merge 2 commits into from

Conversation

mbarrien
Copy link

@mbarrien mbarrien commented Dec 3, 2015

For people who have "bunch" spread all over the codebase from the library, this adds the old Bunch/bunchify/unbunchify names that call Munch/munchify/unmunchify respectively. This allows having the change in code when switching to munch be restricted just to a library name change.

For people who have "bunch" spread all over the codebase from the library, this adds the old Bunch/bunchify/unbunchify names that call Munch/munchify/unmunchify respectively. This allows having the change in code when switching to munch be restricted just to a library name change.
@drrlvn
Copy link

drrlvn commented Dec 3, 2015

You put the backward compatibility assignments in the wrong place -- between a try and its except. This causes a SyntaxError exception, as you can see in Travis.
You should move the code further down, after the except block.

Stupid misplacement.
@mbarrien
Copy link
Author

mbarrien commented Dec 3, 2015

Fixed my boneheaded error.

@vmalloc
Copy link

vmalloc commented Dec 4, 2015

Sorry - I'm not a big fan of dragging legacy around for no apparent reason. You're already greping or seding your files for the import bunch -> import munch change, and bunchify/unbunchify are unique enough to be solved by another grep or sed...

Accepting this change means we'll forever be confused about what a given piece of code uses, instead of just moving forward.

@vmalloc vmalloc closed this Dec 4, 2015
@mbarrien
Copy link
Author

mbarrien commented Dec 4, 2015

I'll be frank here... I'm trying to convince someone else in my work to move to munch over neobunch, and he's pushing for neobunch because it's less code change. My choice right now is etiher to convince him to grep (across multiple repos), or convince you guys to finish convincing the neobunch project to do the merge. Otherwise, neobunch is going to win at my org.

@vmalloc
Copy link

vmalloc commented Dec 4, 2015

Well I honestly think a single sed command is enough to do the transition. If you want we can even try help him with that (if the code is in a repo somewhere I can even help create a PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants