Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new issue about timestamps in comments after 2.4.0 #71

Closed
straw44 opened this issue Feb 11, 2023 · 2 comments
Closed

new issue about timestamps in comments after 2.4.0 #71

straw44 opened this issue Feb 11, 2023 · 2 comments

Comments

@straw44
Copy link

straw44 commented Feb 11, 2023

First of all, I want to thank you for all your work.

I don't know, maybe you are working on this but I decided to open a new issue.

5 days ago, I opened a issue about timestamps in description. #64 (comment)
And a day later, you released 2.4.0.
In this version, you fixed what i said. Thanks.

But now, the main problem is;
You fixed timestamps in description but this update/fix broke timestamps in comments.

I want to divide this issue into two topics. Comments and Description

••••••••••••••••
----Timestamps in COMMENTS (main problem now)
When i click it ,goes to beginning of the video. Video player or PopUp. Same problem for all videos. (It started in 2.4.0)
••••••••••••••••
--Timestamps in DESCRIPTION
You fixed this and works well. But except very small issue (less important )
https://www.youtube.com/watch?v=sKA6o_B0lNs
When I open this video in PopUp player, timestamps in description dont work, not responding.

https://www.youtube.com/watch?v=ED7sZbfiP_k
But in this video, there is no problem with description Timestamps on popup player
••••••••••••••••••

--- If you are going to work on this issue, I think you should check app especially with this two videos after fix. With comment/description timestamps and with main player /popup player seperataly.
https://www.youtube.com/watch?v=sKA6o_B0lNs
https://www.youtube.com/watch?v=ED7sZbfiP_k

---If fixing timestamps in description brakes timestamps in comments and if there is no way to fix together , it is too hard to do or it takes long time, I think you should undo all this fix and go back to 2.3.3 codes about timestamps for now/temporarily.

@InfinityLoop1308
Copy link
Owner

fixed in 2.4.2

@straw44
Copy link
Author

straw44 commented Mar 8, 2023

@InfinityLoop1308 It works flawlessly! Thank you very much. ✨🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants