Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering when pushing and pulling is not kept #26

Closed
abdalem opened this issue Nov 21, 2022 · 7 comments
Closed

Ordering when pushing and pulling is not kept #26

abdalem opened this issue Nov 21, 2022 · 7 comments
Assignees

Comments

@abdalem
Copy link

abdalem commented Nov 21, 2022

We have an issue in my team, when we add envs that depends on others, we need dependencies came after the source env, so sometime we reorder them, or even grouping them by microservice by adding comments (monorepo), but the order is absolutely not kept and same for comments. So each time we pull envs we have to reorder them and add comments.

To be honnest, commenting is not critical, but reordring each time the envs is really annoying.

@maidul98
Copy link
Collaborator

Are you adding your secrets via the UI or using our old NodeJS CLI?

@abdalem
Copy link
Author

abdalem commented Nov 22, 2022

I tried with both and in the UI we cannot reorder (except A->Z - Z->A).

I am trying with the new CLI now, since i could not use it because of the email regex, that you have fixed.

@maidul98
Copy link
Collaborator

Ah i see, so you would like the ability to order your secrets and have them injected in that order?

@abdalem
Copy link
Author

abdalem commented Nov 23, 2022

Yes exactly because I have some envs that depends on each other, example:

BASE_DOMAIN=something.localhost
SERVICE1_DOMAIN=s1.${BASE_DOMAIN}
SERVICE2_DOMAIN=s2.${BASE_DOMAIN}

@maidul98
Copy link
Collaborator

Oh i see, you would like to also reference environment variables created earlier. I'll let you know once we pick this task up.

@maidul98
Copy link
Collaborator

maidul98 commented Nov 26, 2022

Good news, shell parameter expansion is now supported. It is on by default but you can turn it off with --expand=false on the run command. This is noted in the documentation here https://infisical.com/docs/cli/reference/run

Don't forget to update your CLI first! Let me know if things are working for you.

@abdalem
Copy link
Author

abdalem commented Nov 28, 2022

Excellent ! It is working.

@abdalem abdalem closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants