Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error notifications on saving secrets #68

Closed
vmatsiiako opened this issue Dec 4, 2022 · 5 comments · Fixed by #82
Closed

Add error notifications on saving secrets #68

vmatsiiako opened this issue Dec 4, 2022 · 5 comments · Fixed by #82
Assignees
Labels
good first issue Good for newcomers help wanted Open for contributions from the community ✨ UX

Comments

@vmatsiiako
Copy link
Contributor

Feature description

Right now, if you have duplicated secret names (or if a secret name starts with a number), you will not be able to save these secrets to the database.
Users have a visual indication of an error (wrong secret names turn red). However, when they try to save, nothing happens. It would be ideal to show a notification saying "Your secrets weren't saved, please fix the conflicts first."

Why would it be useful?

This is especially useful if users have many secrets. They might not even know that they have some errors. However, they would see a notification as described above.

@vmatsiiako vmatsiiako added help wanted Open for contributions from the community ✨ UX good first issue Good for newcomers labels Dec 4, 2022
@asharonbaltazar
Copy link
Contributor

asharonbaltazar commented Dec 4, 2022

Hey, I'd like to take a shot at this! Seems like a good issue to help familiarize myself with the codebase.

@vmatsiiako
Copy link
Contributor Author

vmatsiiako commented Dec 4, 2022

Hi @asharonbaltazar! That would be amazing! Do you want any help with understanding the codebase? If you'd like, we can schedule a quick call. Let me know!

You're also very welcome to join our community Slack. Here you can ask any questions, and discuss anything related to secrets management and Infisical :) Here is the link: https://join.slack.com/t/infisical-users/shared_invite/zt-1kdbk07ro-RtoyEt_9E~fyzGo_xQYP6g

Thank you so much for your help and let me know if you need anything!

@asharonbaltazar
Copy link
Contributor

Thank you. If you have a development README, I can start from there.
If I need anymore help, I'll be sure to take up your offer! 🙂

@vmatsiiako
Copy link
Contributor Author

We have this: https://infisical.com/docs/contributing/developing

Could you please let me know if you have any more questions? I can write a proper development README

@asharonbaltazar
Copy link
Contributor

That's a good start, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Open for contributions from the community ✨ UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants