Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret referencing not working through Terraform provider #1277

Open
abdalem opened this issue Jan 5, 2024 · 6 comments
Open

Secret referencing not working through Terraform provider #1277

abdalem opened this issue Jan 5, 2024 · 6 comments
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community

Comments

@abdalem
Copy link

abdalem commented Jan 5, 2024

Describe the bug

Hi everyone. Secret referencing is not working through the Terraform provider (see screenshot below).

To Reproduce

Steps to reproduce the behavior:

  1. Create a secret reference in the Dashboard
  2. Implement a Terraform workflow where you output this secret

Expected behavior

The referencing should be parsed and replaced as it is through the CLI (see screenshot below).

Screenshots

Value through Terraform output

Value through Terraform output

Value through CLI

image

Platform you are having the issue on:

Terraform Provider

EDIT

After investigation it seems that when the referencing is straight without any concatenation, it's working, but when you want to concatenate with multple referencing or with a string, it's not.
Example:

  • ${AUTH0_ISSUER} => ✅ OK
  • https://${AUTH0_DOMAIN} => ❌ KO
@vmatsiiako vmatsiiako added 🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community labels Jan 5, 2024
@vmatsiiako
Copy link
Contributor

This indeed has not been implemented for Terraform yet. We will work on this soon.

@abdalem
Copy link
Author

abdalem commented Jan 6, 2024

@vmatsiiako It seems to works when there is no concatenation. Example:

  • ${SOME_OTHER_SECRET} => ✅ OK
  • anything${SOME_OTHER_SECRET} => ❌ KO

Is there any roadmap for this ?

@vmatsiiako
Copy link
Contributor

@maidul98 should be able to comment on this

@maidul98
Copy link
Collaborator

maidul98 commented Jan 8, 2024

@abdalem Terraform provider does not have any logic in it to handle secret referencing. We will aim to add support for this in the coming sprint

@abdalem
Copy link
Author

abdalem commented Jan 10, 2024

@maidul98 So it's pure luck that secrets without concatenation work ? Many devs uses terraform, for me it's more a bug than a feature request, as nowhere in the docs it's stated that secrets referencing does not work through terraform, so as a devops, it should work same way as in dev environnement.

@jithenms
Copy link

jithenms commented Jan 14, 2024

@abdalem Terraform provider does not have any logic in it to handle secret referencing. We will aim to add support for this in the coming sprint

Hey @maidul98 started a PR for this. Was able to successfully test it with a local instance: Infisical/terraform-provider-infisical#30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants