Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The end of a public review period is not present on the detail page #17

Open
KristofVDB1 opened this issue May 22, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@KristofVDB1
Copy link
Contributor

KristofVDB1 commented May 22, 2024

Describe the bug
Some older standards used to have a key called Einde publieke review. This is no longer present in the updated config file: https://github.com/Informatievlaanderen/OSLOthema-perceel/blob/standaardenregister/ap-percelen-config.json#L78C1-L79C1

To Reproduce
Steps to reproduce the behavior:
https://data.vlaanderen.be/standaarden/erkende-standaard/applicatieprofiel-dcat-ap-vl-2.0.html

Expected behavior
Contain the data from the end of a public review period

Screenshots
Screenshot 2024-05-22 at 13 49 28

@KristofVDB1 KristofVDB1 added the bug Something isn't working label May 22, 2024
@KristofVDB1 KristofVDB1 self-assigned this May 22, 2024
@jitsedc
Copy link

jitsedc commented May 22, 2024

If possible it would be good to also capture the date for the start of a public review period too. This way this info is easily retrievable. Currently this info is only captured indirectly via the publication date of a specific version (in the URL) or via the reports of the working group (not easy to find and not always made publicly available).

@KristofVDB1
Copy link
Contributor Author

KristofVDB1 commented May 22, 2024

After a meeting with @bertvannuffelen, we decided to extend the config with a total of three extra dates:

  • Date for the start of a public review
  • Date for the end of a public review
  • Date for the end of a publication (new version of the publication, deprecated,...)

We will keep track of these dates in the config files, but not show them immediately in the frontend. They will also be added to the config template so we don't forget them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants