Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when custom symbology is set and a user zooms out? #319

Closed
torrin47 opened this issue Jan 19, 2017 · 12 comments
Closed

What happens when custom symbology is set and a user zooms out? #319

torrin47 opened this issue Jan 19, 2017 · 12 comments
Assignees
Labels
Milestone

Comments

@torrin47
Copy link
Contributor

Need to consider various options, not mutually exclusive:

  • Popup warning that custom symbology won't be shown
  • Do not allow a user to zoom out when custom symbology is set
  • Set onscreen message
  • Turn layer off
@torrin47 torrin47 added the MVP label Jan 19, 2017
@torrin47 torrin47 added this to the Milestone 32 milestone Mar 2, 2017
@torrin47
Copy link
Contributor Author

torrin47 commented Mar 2, 2017

Based on conversation 2017-03-02, initial MVP functionality should be to not display the tile cache when an alternate symbology is set, and to display a pop-up message letting the user know that dynamic symbology is not visible at small scales, so to reset to default symbology or zoom in to view the data.

Beyond MVP, if dynamic symbology is set, server-side rendering should be used instead of tile cache at small scales. This will be tracked via a new issue #354.

@torrin47 torrin47 modified the milestones: Milestone 32, Milestone 33 Mar 16, 2017
@Baohong
Copy link
Contributor

Baohong commented May 31, 2017

Tiled layer is removed when user change symbology. But the function of "change symbology" will interfere with some other widget functions such as "Select this Community" in pop up message and the format function for popup. I need to fix the issue.

@torrin47
Copy link
Contributor Author

torrin47 commented Jun 7, 2017

Popup message warning working well when selecting change symbology widget and tile layer is removed appropriately, but needs to be re-added when "reset" button is clicked.

@Baohong
Copy link
Contributor

Baohong commented Jun 9, 2017

I am working on this-- the "reset" button. When user click "reset" button, I need a logic to decide whether to show the tile layer. My current logic is, if the feature layer is turned on, then tile layer will be turned on, otherwise, turned off.
But there is a problem with the feature layer's visibility when user click "change appearance" button: take "Carbon storage by tree biomass (kg/m2)" for example, when this layer is added to map but not turned on, after user click "change appearance" item for this layer and zoom to community extent, the feature layer is already visible. I am not sure whether this should be considered as a bug. If it is not a bug, then I have to find another logic to show the tile layer.

@torrin47
Copy link
Contributor Author

torrin47 commented Jun 9, 2017

Yes, this does seem to be a bug. Not quite sure what the best fix is. Seems like we could either:

  1. Automatically turn on the feature layer and check the box when "Change Appearance" is chosen
  2. Ensure that when "Change Appearance" is chosen and layer is not turned on that it does not appear

I'm ok with either, but we do need to do one or the other.

@torrin47
Copy link
Contributor Author

Still seems like some national layers are having difficulty resetting to original symbology, doublecheck code.

@Baohong
Copy link
Contributor

Baohong commented Jun 16, 2017

Could you specify which layer has such issue?

@torrin47
Copy link
Contributor Author

So I'm trying to recreate this bug. As best I can tell, it has to do with whether or not a community has been selected. If a community has been selected, when we try to reset the national layer to its default symbology, it acts like a community layer and looks for a symbology config json file, and when it doesn't find one, it aborts. I know David was looking into this and had already implemented at least one fix, but it seems like we have to keep trying the different scenarios - on/off/community selected, community unselected - to be sure no problems happen.

@brosenbaum
Copy link
Contributor

brosenbaum commented Jun 21, 2017

hey Baohong - there seems to be an issue with the change appearance/dynamic symbology now.
Looks like this:
image

the webhook was broken again today, so your changes weren't automatically pushed during our call today.

@Baohong
Copy link
Contributor

Baohong commented Jun 21, 2017

I run into this problem occasionally, but cannot repeat it. Now for this same layer, I cannot reproduce the problem. So could you repeat this now?

@Baohong
Copy link
Contributor

Baohong commented Jun 22, 2017

"change appearance/dynamic symbology" is working fixed at my end. Please check from your end.

@torrin47
Copy link
Contributor Author

This issue was moved to USEPA/EnviroAtlas_JSApp#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants