Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on notify-rust 4.5.6... are previous versions compatible #66

Closed
gbcox opened this issue May 16, 2022 · 4 comments
Closed

Dependency on notify-rust 4.5.6... are previous versions compatible #66

gbcox opened this issue May 16, 2022 · 4 comments
Labels
question Further information is requested

Comments

@gbcox
Copy link

gbcox commented May 16, 2022

I'm looking at packaging rescrobbled for fedora and ran into an issue with notify-rust. Apparently there are some packages in Fedora that aren't compatible with 4.5.6 due to the changes to zbus/zvariant so that is holding up the ability to upgrade to 4.5.6 or greater.

My question is will 4.5.3 for example work fine? Thanks!

@InputUsername
Copy link
Owner

Hi, I just built with notify-rust 4.5.3 and it compiles and works perfectly fine. In fact before rescrobbled v0.5.2 the version of notify-rust was only pinned at major version 4, so in theory any 4.x.y release should work.

Is there anything else I need to do? (eg. downgrade notify-rust from 4.5.6 to 4.5.3)

Thanks!

@gbcox
Copy link
Author

gbcox commented May 17, 2022

Thanks for the quick response. Right now you don't need to take any action. I'm going through the build process and am running into the same type of issues with the other dependencies. I'm finding that unfortunately with rust packages the dependencies don't always (and I'm finding it's more often than not) accurately reflect what is actually required, so I'm having to manually patch as I encounter, and then the dependencies have dependencies that also have dependencies that have the same issue. Some of the dependencies are quite old and with them when trying to compile I'm getting errors that features they use are now deprecated or missing. Packages in Fedora must have all the required source in the Fedora repository. Additionally, we need to be using the latest versions. If a lower version is required, we then need to create a special compatibility version of that release. It's a mess.

@InputUsername InputUsername added the question Further information is requested label May 24, 2022
@InputUsername
Copy link
Owner

@gbcox Not sure if it helps in any way, but I just released 0.7.0 which removes the dependency on notify-rust altogether.

@InputUsername
Copy link
Owner

Closing this for now, feel free to reopen or make another issue if there's anything I can help with to get a Fedora package working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants