Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki mistake #163

Closed
Fma965 opened this issue Apr 9, 2023 · 3 comments · Fixed by #165
Closed

Wiki mistake #163

Fma965 opened this issue Apr 9, 2023 · 3 comments · Fixed by #165

Comments

@Fma965
Copy link
Contributor

Fma965 commented Apr 9, 2023

https://github.com/Inrixia/Floatplane-Downloader/blob/master/wiki/docker.md

If you want a interactive session you need to set headless to false, so initial setup should be

 $ docker run -it \
    	-v [path]:/fp/db \
    	-v [path]:/fp/videos \
    	-e headless="FALSE" \
    	-e runQuickstartPrompts=true \
    	--restart unless-stopped \
        inrix/floatplane-downloader

NOT

 $ docker run -it \
    	-v [path]:/fp/db \
    	-v [path]:/fp/videos \
    	-e headless="TRUE" \
    	-e runQuickstartPrompts=true \
    	--restart unless-stopped \
        inrix/floatplane-downloader
@Inrixia
Copy link
Owner

Inrixia commented Apr 9, 2023

Default is no headless so you can actually just remove the argument.

Feel free to open a PR to fix this, otherwise Ill eventually get to it. Thanks for noticing it

@Fma965
Copy link
Contributor Author

Fma965 commented Apr 9, 2023

Ofcourse, i just spend like 10 minutes trying to figure out why interactive wasn't working 😆

This was referenced Apr 9, 2023
@Inrixia Inrixia linked a pull request Apr 9, 2023 that will close this issue
@Inrixia Inrixia closed this as completed Apr 9, 2023
@Fma965
Copy link
Contributor Author

Fma965 commented Apr 9, 2023

It's still wrong on the master branch though, which is where most people are going to read the instructions.

Hence why i PR'd it for both. (as it's not a code change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants