Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable catalog refresh timer by default #360

Open
olevitt opened this issue Jan 30, 2024 · 0 comments · May be fixed by #363
Open

Disable catalog refresh timer by default #360

olevitt opened this issue Jan 30, 2024 · 0 comments · May be fixed by #363

Comments

@olevitt
Copy link
Contributor

olevitt commented Jan 30, 2024

Currently Onyxia refresh the catalogs every 5 minutes (see https://github.com/InseeFrLab/onyxia-api?tab=readme-ov-file#catalogs-configuration- catalogs.refresh.ms).
There are some caveats associated with catalog refreshs :

  • In case you have multiple API pods, having one refreshed and not the other means they may be desynched resulting in user facing bugs
  • Refresh may fail due to a temporary failure in registry
  • Refreshing the catalogs and fetching all packages every x minutes may cause some heavy load (see Add modes for filtering versions of charts to keep #358 for possible mitigation)
  • Periodic refresh on catalogs you don't maintain yourself may result in app breaking unexpectedly

I suggest we disable the refresh by default (setting 0 to catalogs.refresh.ms by default) while still allowing admin to override it. I also suggest we document the caveats.

@olevitt olevitt changed the title Change default catalog refresh timer Disable catalog refresh timer by default Jan 30, 2024
@olevitt olevitt linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant