Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Apple Silicon #1192

Merged
merged 6 commits into from Nov 18, 2021
Merged

Add Support for Apple Silicon #1192

merged 6 commits into from Nov 18, 2021

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Oct 28, 2021

No description provided.

@arnaudgiuliani arnaudgiuliani added this to the 3.1.4 milestone Oct 29, 2021
@arnaudgiuliani arnaudgiuliani added the status:accepted accepted to be developed label Oct 29, 2021
Copy link
Contributor

@russhwolf russhwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a new tvos simulator target

core/koin-core/build.gradle Show resolved Hide resolved
core/koin-core/build.gradle Show resolved Hide resolved
core/koin-test/build.gradle Show resolved Hide resolved
Co-authored-by: Russell Wolf <russhwolf@users.noreply.github.com>
@dcvz
Copy link
Contributor Author

dcvz commented Nov 6, 2021

Pulled in the suggestions, thanks @russhwolf !

Co-authored-by: Stephen Caraher <moskvax@gmail.com>
@dcvz
Copy link
Contributor Author

dcvz commented Nov 14, 2021

Thanks @moskvax !

@arnaudgiuliani
Copy link
Member

Great. Can you fix conflicts @dcvz 🙏

@dcvz
Copy link
Contributor Author

dcvz commented Nov 17, 2021

done @arnaudgiuliani !

@arnaudgiuliani
Copy link
Member

great 👌

@arnaudgiuliani arnaudgiuliani merged commit aaad0fe into InsertKoinIO:master Nov 18, 2021
@dcvz dcvz deleted the feature/apple-silicon-support branch November 18, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core multiplatform kmp status:accepted accepted to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants