Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktor 3.0 support #1716

Open
lexa-diky opened this issue Nov 27, 2023 · 8 comments
Open

Ktor 3.0 support #1716

lexa-diky opened this issue Nov 27, 2023 · 8 comments
Assignees
Labels
ktor status:checking currently in analysis - discussion or need more detailed specs type:feature-proposal
Milestone

Comments

@lexa-diky
Copy link

Is your feature request related to a problem? Please describe.
JB recently released Ktor 3.0.0-betta1. Currently Ktor does not support it, JB changed API. In particular access to monitor now done via Application not Environment, maybe there is more incompatibilities.

Describe the solution you'd like
Separate ktor-3 module to have both ktor 2.* and 3.*

Target Koin project
ktor

@Nek-12
Copy link

Nek-12 commented Dec 3, 2023

Can second this, but I would prefer a simple dependency upgrade instead of separate artifact

@Nek-12
Copy link

Nek-12 commented Dec 13, 2023

The workaround for now is to copy everything from the koin Ktor sources and fix the compile time error

@lexa-diky
Copy link
Author

If koin goes with single module approach, it will break comp with ktor-2, and I guess bunch of people will not update for a while

@Nek-12
Copy link

Nek-12 commented Dec 13, 2023

The only updates for the past months have been dependency updates... The whole library is 2 files

@arnaudgiuliani arnaudgiuliani added ktor status:checking currently in analysis - discussion or need more detailed specs type:feature-proposal labels Dec 13, 2023
@arnaudgiuliani arnaudgiuliani self-assigned this Dec 13, 2023
@arnaudgiuliani
Copy link
Member

Yes, great topic coming 👍

@Nek-12
Copy link

Nek-12 commented Dec 25, 2023

Can you please add ktor 3.0 support first before you refactor, add new stuff, and break something with the update you described in your article? @arnaudgiuliani

Changing one line of code, that is, so that we don't wait till Q4 2024 for this to get fixed

@arnaudgiuliani arnaudgiuliani added this to the ktor-3.6.0 milestone Jan 25, 2024
@arnaudgiuliani
Copy link
Member

something I can setup for 3.6.0 - Q1
Seems that we need to separate both ktor & ktor3

@FlyingYu-Z
Copy link

Is there any solution now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ktor status:checking currently in analysis - discussion or need more detailed specs type:feature-proposal
Projects
None yet
Development

No branches or pull requests

4 participants