Skip to content

Commit 140f3c2

Browse files
committed
ENH: Drop support for MSVC toolset v141 aka Visual Studio 2017
Enabling C++17 broke VS2017 due to its numerous bugs. See discussion: https://discourse.itk.org/t/c-17-breaks-visual-studio-2017-drop-support/5884
1 parent a0c67bb commit 140f3c2

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

CMake/itkCompilerChecks.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ endif ()
1818

1919
# Minimum compiler version check: Microsoft C/C++
2020
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND
21-
CMAKE_CXX_COMPILER_VERSION VERSION_LESS 19.14)
22-
message(FATAL_ERROR "Microsoft Visual Studio 2017 15.7 (MSVC 19.14) or later is required.")
21+
CMAKE_CXX_COMPILER_VERSION VERSION_LESS 19.20)
22+
message(FATAL_ERROR "Microsoft Visual Studio 2019 16.0 (MSVC 19.20) or later is required.")
2323
endif ()
2424

2525
# Minimum compiler version check: Intel C++ (ICC)

Documentation/SupportedCompilers.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
ITK requires a compiler with C++17 support.
22

33
# Visual Studio
4-
* VS2015 and earlier: **NOT supported**
5-
* MSVC toolset v141 (first shipped with VS2017): supported from VS2017 version 15.7
4+
* VS2017 and earlier: **NOT supported**
65
* MSVC toolset v142 (first shipped with VS2019): supported
76
* MSVC toolset v143 (first shipped with VS2022): supported
87

Modules/Core/Common/include/itkMacro.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,14 +151,11 @@ namespace itk
151151
#endif
152152

153153
/*
154-
* ITK only supports MSVC++ 14.14 and greater
155-
* MSVC++ 14.14 _MSC_VER == 1914 (Visual Studio 2017 version 15.7)
156-
* MSVC++ 14.15 _MSC_VER == 1915 (Visual Studio 2017 version 15.8)
157-
* MSVC++ 14.16 _MSC_VER == 1916 (Visual Studio 2017 version 15.9)
154+
* ITK only supports MSVC++ 14.2 and greater
158155
* MSVC++ 14.2 _MSC_VER == 1920 (Visual Studio 2019 Version 16.0)
159156
*/
160-
#if defined(_MSC_VER) && (_MSC_VER < 1914)
161-
# error "MSVC version before Visual Studio 2017 version 15.7 is not supported under ITKv5.4"
157+
#if defined(_MSC_VER) && (_MSC_VER < 1920)
158+
# error "MSVC versions before Visual Studio 2019 are not supported under ITKv5.4"
162159
#endif
163160
#if defined(__SUNPRO_CC) && (__SUNPRO_CC < 0x5140)
164161
# error "SUNPro C++ < 5.14.0 is not supported under ITKv5 and above"

0 commit comments

Comments
 (0)