STYLE: Simply assign factories, in ObjectFactoryBase::RegisterInternal()

Replaced `clear` and `push_back` calls with a simple `std::list` assignment to `m_RegisteredFactories`.
InsightSoftwareConsortium · Oct 4, 2023 · 2859d67 · 2859d67
1 parent 75b9967
commit 2859d67
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/Modules/Core/Common/src/itkObjectFactoryBase.cxx b/Modules/Core/Common/src/itkObjectFactoryBase.cxx
@@ -249,14 +249,9 @@ ObjectFactoryBase::RegisterInternal()
 
   // Guarantee that no internal factories have already been registered.
   itkAssertInDebugAndIgnoreInReleaseMacro(m_PimplGlobals->m_RegisteredFactories.empty());
-  m_PimplGlobals->m_RegisteredFactories.clear();
 
-  // Register all factories registered by the
-  // "RegisterFactoryInternal" method
-  for (auto & internalFactory : m_PimplGlobals->m_InternalFactories)
-  {
-    m_PimplGlobals->m_RegisteredFactories.push_back(internalFactory);
-  }
+  // Register all factories registered by the "RegisterFactoryInternal" method
+  m_PimplGlobals->m_RegisteredFactories = m_PimplGlobals->m_InternalFactories;
 }
 
 /**