Skip to content

Commit 291e618

Browse files
committed
DOC: Document miscellaneous cell class methods in header files
Document miscellaneous cell class methods in header files: Doxygen picks the method documentation from the header files, and leaves the method documentation empty if it does not find it there. Increase consistency in the characters used for documentation blocks and follow the ITK SW Guideline: prefer using single-line comments for separation of logical blocks. Take advantage of the commit to fix typos in the method documentation.
1 parent cdbbdf9 commit 291e618

File tree

6 files changed

+104
-203
lines changed

6 files changed

+104
-203
lines changed

Modules/Core/Common/include/itkTetrahedronCell.h

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class ITK_TEMPLATE_EXPORT TetrahedronCell
4444
public:
4545
ITK_DISALLOW_COPY_AND_MOVE(TetrahedronCell);
4646

47-
/** Standard class type aliasa. */
47+
/** Standard class type alias. */
4848
itkCellCommonTypedefs(TetrahedronCell);
4949
itkCellInheritedTypedefs(TCellInterface);
5050

@@ -70,6 +70,8 @@ class ITK_TEMPLATE_EXPORT TetrahedronCell
7070
static constexpr unsigned int NumberOfFaces = 4;
7171
static constexpr unsigned int CellDimension = 3;
7272

73+
// Standard CellInterface
74+
7375
/** Implement the standard CellInterface. */
7476
CellGeometryEnum
7577
GetType() const override
@@ -79,51 +81,86 @@ class ITK_TEMPLATE_EXPORT TetrahedronCell
7981
void
8082
MakeCopy(CellAutoPointer &) const override;
8183

84+
/** Get the topological dimension of this cell. */
8285
unsigned int
8386
GetDimension() const override;
8487

88+
/** Get the number of points required to define the cell. */
8589
unsigned int
8690
GetNumberOfPoints() const override;
8791

92+
/** Get the number of boundary features of the given dimension. */
8893
CellFeatureCount
8994
GetNumberOfBoundaryFeatures(int dimension) const override;
9095

96+
/** Get the boundary feature of the given dimension specified by the given cell feature Id.
97+
* The Id can range from 0 to GetNumberOfBoundaryFeatures(dimension)-1.
98+
*/
9199
bool
92100
GetBoundaryFeature(int dimension, CellFeatureIdentifier, CellAutoPointer &) override;
101+
102+
/** Set the point id list used by the cell. It is assumed that the given iterator can be incremented and safely
103+
* de-referenced enough times to get all the point ids needed by the cell.
104+
*/
93105
void
94106
SetPointIds(PointIdConstIterator first) override;
95107

108+
/** Set the point id list used by the cell. It is assumed that the range of iterators [first, last) contains the
109+
* correct number of points needed to define the cell. The position *last is NOT referenced, so it can safely be
110+
* one beyond the end of an array or other container.
111+
*/
96112
void
97113
SetPointIds(PointIdConstIterator first, PointIdConstIterator last) override;
98114

115+
/** Set an individual point identifier in the cell. */
99116
void
100117
SetPointId(int localId, PointIdentifier) override;
118+
119+
/** Get a begin iterator to the list of point identifiers used by the cell. */
101120
PointIdIterator
102121
PointIdsBegin() override;
103122

123+
/** Get a const begin iterator to the list of point identifiers used by the cell. */
104124
PointIdConstIterator
105125
PointIdsBegin() const override;
106126

127+
/** Get an end iterator to the list of point identifiers used by the cell. */
107128
PointIdIterator
108129
PointIdsEnd() override;
109130

131+
/** Get a const end iterator to the list of point identifiers used by the cell. */
110132
PointIdConstIterator
111133
PointIdsEnd() const override;
112134

113-
/** Tetrahedron-specific interface. */
135+
// Tetrahedron-specific interface
136+
137+
/** Get the number of vertices defining the tetrahedron. */
114138
virtual CellFeatureCount
115139
GetNumberOfVertices() const;
116140

141+
/** Get the number of edges defined for the tetrahedron. */
117142
virtual CellFeatureCount
118143
GetNumberOfEdges() const;
119144

145+
/** Get the number of faces defined for the tetrahedron. */
120146
virtual CellFeatureCount
121147
GetNumberOfFaces() const;
122148

149+
/** Get the vertex specified by the given cell feature Id.
150+
* The Id can range from 0 to GetNumberOfVertices()-1.
151+
*/
123152
virtual bool
124153
GetVertex(CellFeatureIdentifier, VertexAutoPointer &);
154+
155+
/** Get the edge specified by the given cell feature Id.
156+
* The Id can range from 0 to GetNumberOfEdges()-1.
157+
*/
125158
virtual bool
126159
GetEdge(CellFeatureIdentifier, EdgeAutoPointer &);
160+
161+
/** Get the face specified by the given cell feature Id.
162+
* The Id can range from 0 to GetNumberOfFaces()-1.
163+
*/
127164
virtual bool
128165
GetFace(CellFeatureIdentifier, FaceAutoPointer &);
129166

Modules/Core/Common/include/itkTetrahedronCell.hxx

Lines changed: 1 addition & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323

2424
namespace itk
2525
{
26-
/**
27-
* Standard CellInterface:
28-
*/
26+
2927
template <typename TCellInterface>
3028
void
3129
TetrahedronCell<TCellInterface>::MakeCopy(CellAutoPointer & cellPointer) const
@@ -34,32 +32,20 @@ TetrahedronCell<TCellInterface>::MakeCopy(CellAutoPointer & cellPointer) const
3432
cellPointer->SetPointIds(this->GetPointIds());
3533
}
3634

37-
/**
38-
* Standard CellInterface:
39-
* Get the topological dimension of this cell.
40-
*/
4135
template <typename TCellInterface>
4236
unsigned int
4337
TetrahedronCell<TCellInterface>::GetDimension() const
4438
{
4539
return Self::CellDimension;
4640
}
4741

48-
/**
49-
* Standard CellInterface:
50-
* Get the number of points required to define the cell.
51-
*/
5242
template <typename TCellInterface>
5343
unsigned int
5444
TetrahedronCell<TCellInterface>::GetNumberOfPoints() const
5545
{
5646
return Self::NumberOfPoints;
5747
}
5848

59-
/**
60-
* Standard CellInterface:
61-
* Get the number of boundary features of the given dimension.
62-
*/
6349
template <typename TCellInterface>
6450
auto
6551
TetrahedronCell<TCellInterface>::GetNumberOfBoundaryFeatures(int dimension) const -> CellFeatureCount
@@ -220,12 +206,6 @@ TetrahedronCell<TCellInterface>::EvaluatePosition(CoordRepType * x,
220206
return false;
221207
}
222208

223-
/**
224-
* Standard CellInterface:
225-
* Get the boundary feature of the given dimension specified by the given
226-
* cell feature Id.
227-
* The Id can range from 0 to GetNumberOfBoundaryFeatures(dimension)-1.
228-
*/
229209
template <typename TCellInterface>
230210
bool
231211
TetrahedronCell<TCellInterface>::GetBoundaryFeature(int dimension,
@@ -271,26 +251,13 @@ TetrahedronCell<TCellInterface>::GetBoundaryFeature(int dimens
271251
return false;
272252
}
273253

274-
/**
275-
* Standard CellInterface:
276-
* Set the point id list used by the cell. It is assumed that the given
277-
* iterator can be incremented and safely de-referenced enough times to
278-
* get all the point ids needed by the cell.
279-
*/
280254
template <typename TCellInterface>
281255
void
282256
TetrahedronCell<TCellInterface>::SetPointIds(PointIdConstIterator first)
283257
{
284258
std::copy_n(first, Self::NumberOfPoints, m_PointIds.begin());
285259
}
286260

287-
/**
288-
* Standard CellInterface:
289-
* Set the point id list used by the cell. It is assumed that the range
290-
* of iterators [first, last) contains the correct number of points needed to
291-
* define the cell. The position *last is NOT referenced, so it can safely
292-
* be one beyond the end of an array or other container.
293-
*/
294261
template <typename TCellInterface>
295262
void
296263
TetrahedronCell<TCellInterface>::SetPointIds(PointIdConstIterator first, PointIdConstIterator last)
@@ -304,101 +271,62 @@ TetrahedronCell<TCellInterface>::SetPointIds(PointIdConstIterator first, PointId
304271
}
305272
}
306273

307-
/**
308-
* Standard CellInterface:
309-
* Set an individual point identifier in the cell.
310-
*/
311274
template <typename TCellInterface>
312275
void
313276
TetrahedronCell<TCellInterface>::SetPointId(int localId, PointIdentifier ptId)
314277
{
315278
m_PointIds[localId] = ptId;
316279
}
317280

318-
/**
319-
* Standard CellInterface:
320-
* Get a begin iterator to the list of point identifiers used by the cell.
321-
*/
322281
template <typename TCellInterface>
323282
auto
324283
TetrahedronCell<TCellInterface>::PointIdsBegin() -> PointIdIterator
325284
{
326285
return &m_PointIds[0];
327286
}
328287

329-
/**
330-
* Standard CellInterface:
331-
* Get a const begin iterator to the list of point identifiers used
332-
* by the cell.
333-
*/
334288
template <typename TCellInterface>
335289
auto
336290
TetrahedronCell<TCellInterface>::PointIdsBegin() const -> PointIdConstIterator
337291
{
338292
return &m_PointIds[0];
339293
}
340294

341-
/**
342-
* Standard CellInterface:
343-
* Get an end iterator to the list of point identifiers used by the cell.
344-
*/
345295
template <typename TCellInterface>
346296
auto
347297
TetrahedronCell<TCellInterface>::PointIdsEnd() -> PointIdIterator
348298
{
349299
return &m_PointIds[Self::NumberOfPoints - 1] + 1;
350300
}
351301

352-
/**
353-
* Standard CellInterface:
354-
* Get a const end iterator to the list of point identifiers used
355-
* by the cell.
356-
*/
357302
template <typename TCellInterface>
358303
auto
359304
TetrahedronCell<TCellInterface>::PointIdsEnd() const -> PointIdConstIterator
360305
{
361306
return &m_PointIds[Self::NumberOfPoints - 1] + 1;
362307
}
363308

364-
/**
365-
* Tetrahedron-specific:
366-
* Get the number of vertices defining the tetrahedron.
367-
*/
368309
template <typename TCellInterface>
369310
auto
370311
TetrahedronCell<TCellInterface>::GetNumberOfVertices() const -> CellFeatureCount
371312
{
372313
return Self::NumberOfVertices;
373314
}
374315

375-
/**
376-
* Tetrahedron-specific:
377-
* Get the number of edges defined for the tetrahedron.
378-
*/
379316
template <typename TCellInterface>
380317
auto
381318
TetrahedronCell<TCellInterface>::GetNumberOfEdges() const -> CellFeatureCount
382319
{
383320
return Self::NumberOfEdges;
384321
}
385322

386-
/**
387-
* Tetrahedron-specific:
388-
* Get the number of faces defined for the tetrahedron.
389-
*/
390323
template <typename TCellInterface>
391324
auto
392325
TetrahedronCell<TCellInterface>::GetNumberOfFaces() const -> CellFeatureCount
393326
{
394327
return Self::NumberOfFaces;
395328
}
396329

397-
/**
398-
* Tetrahedron-specific:
399-
* Get the vertex specified by the given cell feature Id.
400-
* The Id can range from 0 to GetNumberOfVertices()-1.
401-
*/
402330
template <typename TCellInterface>
403331
bool
404332
TetrahedronCell<TCellInterface>::GetVertex(CellFeatureIdentifier vertexId, VertexAutoPointer & vertexPointer)
@@ -410,11 +338,6 @@ TetrahedronCell<TCellInterface>::GetVertex(CellFeatureIdentifier vertexId, Verte
410338
return true;
411339
}
412340

413-
/**
414-
* Tetrahedron-specific:
415-
* Get the edge specified by the given cell feature Id.
416-
* The Id can range from 0 to GetNumberOfEdges()-1.
417-
*/
418341
template <typename TCellInterface>
419342
bool
420343
TetrahedronCell<TCellInterface>::GetEdge(CellFeatureIdentifier edgeId, EdgeAutoPointer & edgePointer)
@@ -429,11 +352,6 @@ TetrahedronCell<TCellInterface>::GetEdge(CellFeatureIdentifier edgeId, EdgeAutoP
429352
return true;
430353
}
431354

432-
/**
433-
* Tetrahedron-specific:
434-
* Get the face specified by the given cell feature Id.
435-
* The Id can range from 0 to GetNumberOfFaces()-1.
436-
*/
437355
template <typename TCellInterface>
438356
bool
439357
TetrahedronCell<TCellInterface>::GetFace(CellFeatureIdentifier faceId, FaceAutoPointer & facePointer)

0 commit comments

Comments
 (0)