BUG: FixedParameters should be double precision

In order for tranforms to properly represent the fixed
parameters (i.e. size/spacing/direction of displacement fields)
it is required that the FixedParameters are of type double.

Change-Id: I6c08aaa496cbf86a1a17620e161a54eec3d4ad43

Modules/Core/Transform/include/itkTransformBase.h

@@ -53,9 +53,22 @@ class TransformBaseTemplate:public Object
 
   typedef  TParametersValueType                          ParametersValueType;
   typedef  OptimizerParameters<ParametersValueType>      ParametersType;
-  typedef  ParametersValueType                           FixedParametersValueType;
+  typedef  double                                        FixedParametersValueType;
   typedef  OptimizerParameters<FixedParametersValueType> FixedParametersType;
 
+// The ITK_FIXED_PARAMETERS_ARE_DOUBLE is intended
+// to facilitate transition of ITK for those very
+// rare cases where multiple versions of ITK
+// may need to be supported simultaneously.
+#if defined( ITK_LEGACY_REMOVE )
+  #undef  ITK_FIXED_PARAMETERS_ARE_DOUBLE
+#else
+  #define ITK_FIXED_PARAMETERS_ARE_DOUBLE
+  // #if !defined(ITK_FIXED_PARAMETERS_ARE_DOUBLE)
+  // typedef ParametersValueType FixedParametersValueType;
+  // #endif
+#endif
+
   /** Run-time type information (and related methods). */
   itkTypeMacro(TransformBaseTemplate, Object);
 

Modules/IO/TransformBase/include/itkTransformFileWriter.h

@@ -45,7 +45,7 @@ class TransformFileWriterTemplate:public LightProcessObject
   typedef SmartPointer<const Self>    ConstPointer;
 
   typedef TParametersValueType                             ParametersValueType;
-  typedef ParametersValueType                              FixedParametersValueType;
+  typedef double                                           FixedParametersValueType;
   typedef TransformBaseTemplate<ParametersValueType>       TransformType;
   typedef TransformIOBaseTemplate<ParametersValueType>     TransformIOType;
   typedef typename TransformIOType::TransformPointer       TransformPointer;

Modules/IO/TransformHDF5/include/itkHDF5TransformIO.hxx

@@ -141,10 +141,6 @@ HDF5TransformIOTemplate<TParametersValueType>
 {
   const hsize_t dim(fixedParameters.Size());
   FixedParametersValueType *buf = new FixedParametersValueType[dim];
-
-  const std::string & NameParametersValueTypeString = Superclass::GetTypeNameString();
-  if( ! NameParametersValueTypeString.compare( std::string("double") ))
-  {
   for(unsigned i(0); i < dim; i++)
     {
     buf[i] = fixedParameters[i];
@@ -155,26 +151,6 @@ HDF5TransformIOTemplate<TParametersValueType>
     paramSpace);
   paramSet.write(buf,H5::PredType::NATIVE_DOUBLE);
   paramSet.close();
-  }
-  else if( ! NameParametersValueTypeString.compare(std::string("float") ) )
-  {
-  for(unsigned i(0); i < dim; i++)
-    {
-    buf[i] = fixedParameters[i];
-    }
-  H5::DataSpace paramSpace(1,&dim);
-  H5::DataSet paramSet = this->m_H5File->createDataSet(name,
-    H5::PredType::NATIVE_FLOAT,
-    paramSpace);
-  paramSet.write(buf,H5::PredType::NATIVE_FLOAT);
-  paramSet.close();
-  }
-  else
-  {
-  itkExceptionMacro(<< "Wrong data precision type "
-    << NameParametersValueTypeString
-    << "for writing in HDF5 File");
-  }
   delete [] buf;
 }
 
@@ -413,7 +389,7 @@ HDF5TransformIOTemplate<TParametersValueType>
     FixedParametersType FixedtmpArray = curTransform->GetFixedParameters();
     std::string fixedParamsName(transformName);
     fixedParamsName += transformFixedName;
-    this->WriteParameters(fixedParamsName,FixedtmpArray);
+    this->WriteFixedParameters(fixedParamsName,FixedtmpArray);
     // parameters
     ParametersType tmpArray = curTransform->GetParameters();
     std::string paramsName(transformName);