STYLE: Default default-constructor of MinimumMaximumImageCalculator

InsightSoftwareConsortium · Feb 23, 2023 · 791e2d4 · 791e2d4
1 parent b9e0813
commit 791e2d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/Modules/Core/Common/include/itkMinimumMaximumImageCalculator.h b/Modules/Core/Common/include/itkMinimumMaximumImageCalculator.h
@@ -18,6 +18,7 @@
 #ifndef itkMinimumMaximumImageCalculator_h
 #define itkMinimumMaximumImageCalculator_h
 
+#include "itkNumericTraits.h"
 #include "itkObject.h"
 #include "itkObjectFactory.h"
 
@@ -108,15 +109,15 @@ class ITK_TEMPLATE_EXPORT MinimumMaximumImageCalculator : public Object
   SetRegion(const RegionType & region);
 
 protected:
-  MinimumMaximumImageCalculator();
+  MinimumMaximumImageCalculator() = default;
   ~MinimumMaximumImageCalculator() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;
 
 private:
-  PixelType         m_Minimum{};
-  PixelType         m_Maximum{};
-  ImageConstPointer m_Image{};
+  PixelType         m_Minimum{ NumericTraits<PixelType>::max() };
+  PixelType         m_Maximum{ NumericTraits<PixelType>::NonpositiveMin() };
+  ImageConstPointer m_Image{ TInputImage::New() };
 
   IndexType m_IndexOfMinimum{};
   IndexType m_IndexOfMaximum{};

diff --git a/Modules/Core/Common/include/itkMinimumMaximumImageCalculator.hxx b/Modules/Core/Common/include/itkMinimumMaximumImageCalculator.hxx
@@ -19,22 +19,10 @@
 #define itkMinimumMaximumImageCalculator_hxx
 
 #include "itkImageRegionConstIteratorWithIndex.h"
-#include "itkNumericTraits.h"
 
 namespace itk
 {
 
-template <typename TInputImage>
-MinimumMaximumImageCalculator<TInputImage>::MinimumMaximumImageCalculator()
-{
-  m_Image = TInputImage::New();
-  m_Maximum = NumericTraits<PixelType>::NonpositiveMin();
-  m_Minimum = NumericTraits<PixelType>::max();
-  m_IndexOfMinimum.Fill(0);
-  m_IndexOfMaximum.Fill(0);
-  m_RegionSetByUser = false;
-}
-
 template <typename TInputImage>
 void
 MinimumMaximumImageCalculator<TInputImage>::Compute()