STYLE: Default default-constructor SimpleDataObjectDecorator

Removed obsolete "-Wmaybe-uninitialized" and Purify UMR (uninitialized memory read) workarounds.
InsightSoftwareConsortium · Apr 24, 2023 · 7a89717 · 7a89717
1 parent 788e558
commit 7a89717
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 20 deletions.
diff --git a/Modules/Core/Common/include/itkSimpleDataObjectDecorator.h b/Modules/Core/Common/include/itkSimpleDataObjectDecorator.h
@@ -100,7 +100,7 @@ class ITK_TEMPLATE_EXPORT SimpleDataObjectDecorator : public DataObject
   }
 
 protected:
-  SimpleDataObjectDecorator();
+  SimpleDataObjectDecorator() = default;
   ~SimpleDataObjectDecorator() override = default;
   void
   PrintSelf(std::ostream & os, Indent indent) const override;

diff --git a/Modules/Core/Common/include/itkSimpleDataObjectDecorator.hxx b/Modules/Core/Common/include/itkSimpleDataObjectDecorator.hxx
@@ -32,25 +32,6 @@
 
 namespace itk
 {
-/**
- *
- */
-template <typename T>
-SimpleDataObjectDecorator<T>::SimpleDataObjectDecorator()
-{
-#if defined(__GNUC__) && (__GNUC__ > 6)
-  ITK_GCC_PRAGMA_DIAG_PUSH()
-  ITK_GCC_PRAGMA_DIAG(ignored "-Wmaybe-uninitialized")
-#endif                                 // defined( __GNUC__ ) && ( __GNUC__ > 6 )
-  this->m_Component = ComponentType(); // initialize here to avoid Purify UMR
-#if defined(__GNUC__) && (__GNUC__ > 6)
-  ITK_GCC_PRAGMA_DIAG_POP()
-#endif                         // defined( __GNUC__ ) && ( __GNUC__ > 6 )
-  this->m_Initialized = false; // Still needed since not all objects
-                               // are initialized at construction time.
-                               // for example the itkArray.
-}
-
 /**
  *
  */