Skip to content

Commit

Permalink
BUG: DICOMParser should use && instead of comma in for-loop condition
Browse files Browse the repository at this point in the history
Fixed the following warning from Visual C++ 2019:

> DICOMParser.cxx(830,14): warning C4834: discarding return value of
> function with 'nodiscard' attribute

Potentially a serious bug.
  • Loading branch information
N-Dekker authored and hjmjohnson committed Dec 11, 2020
1 parent 12e8d93 commit c90bfa4
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -827,7 +827,7 @@ void DICOMParser::GetGroupsElementsDatatypes(dicom_stl::vector<doublebyte>& grou
dicom_stl::vector<DICOMParser::VRTypes>::iterator diter; // = this->Datatypes.begin();

for (giter = this->Implementation->Groups.begin(), eiter = this->Implementation->Elements.begin(), diter = this->Implementation->Datatypes.begin();
giter != this->Implementation->Groups.end(), eiter != this->Implementation->Elements.end(), diter != this->Implementation->Datatypes.end();
giter != this->Implementation->Groups.end() && eiter != this->Implementation->Elements.end() && diter != this->Implementation->Datatypes.end();
giter++, eiter++, diter++)
{
groups.push_back(*giter);
Expand Down

0 comments on commit c90bfa4

Please sign in to comment.