Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Danielsson distance filter use pixel type of Offset<>, which does not have a specialized NumericTraits. #2961

Open
blowekamp opened this issue Dec 15, 2021 · 2 comments
Open

The Danielsson distance filter use pixel type of Offset<>, which does not have a specialized NumericTraits. #2961

blowekamp opened this issue Dec 15, 2021 · 2 comments
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module status:Backlog Postponed without a fixed deadline type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@blowekamp
Copy link
Member

Encountered an issue with the Image::GetNumberOfComponentsPerPixel method not reporting the correct number of components with the results from DanielssonDistanceMapImageFilter::VectorDistanceMap. The resulting image has pixel type Offset which is missing a specialized NumericTraits to get the correct Length.

While the usage of Offset for a pixel type appears to be rather unusual, the proposed fix it to add the additional specialization of NumericTraits.
@blowekamp blowekamp added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Dec 15, 2021
@blowekamp
Copy link
Member Author

The Offset pixel type will be notably incomplete compared to other used pixel type, because the Offset is not templated over the component value type, therefore there cannot be a real, Abs etc pixel type.

@thewtex thewtex added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module labels Dec 22, 2021
@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module status:Backlog Postponed without a fixed deadline type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thewtex @blowekamp