Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce writing commit message bodies #4218

Open
jhlegarreta opened this issue Sep 19, 2023 · 0 comments
Open

Enforce writing commit message bodies #4218

jhlegarreta opened this issue Sep 19, 2023 · 0 comments
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Comments

@jhlegarreta
Copy link
Member

Description

Frequently contributors do not write a commit message body, and it becomes difficult to see the rationale or benefit of the change, or the reason why a particular approach was chosen.

Impact analysis

Not writing a commit message body makes it difficult to understand past changes when navigating the git history, and any relevant exchange may remain only on the GitHub comments.

Expected behavior

We should enforce e.g. through a pre-commit hook writing a commit message body.

Actual behavior

Commit message bodies can be empty.

Versions

master.

Environment

Any.

Additional Information

Although we cannot ensure self-contained, complete message bodies, this will at least avoid empty commit message bodies.

@jhlegarreta jhlegarreta added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

No branches or pull requests

1 participant