Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GHA workflow to check for CMake style #4237

Open
jhlegarreta opened this issue Oct 1, 2023 · 1 comment
Open

Add a GHA workflow to check for CMake style #4237

jhlegarreta opened this issue Oct 1, 2023 · 1 comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Comments

@jhlegarreta
Copy link
Member

jhlegarreta commented Oct 1, 2023 •
edited

Description

Add a GHA workflow to check for CMake style.

Impact analysis

Would allow reporting style inconsistencies in CMake code.

Expected behavior

Report inconsistencies in CMake code style with respect to the defined style for PRs opened when contributors have not configured pre-commit hooks or have been by-passed. Would potentially prevent such code from being merged.

Actual behavior

No GHA workflow is in place to check for CMake code style.

Versions

master.

Environment

Any.

Additional Information

Cross-referencing #4233 (comment).
@jhlegarreta jhlegarreta added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Oct 1, 2023
@thewtex
Copy link
Member

thewtex commented Oct 1, 2023

xref #4235 where we can have a pre-commit cmake-lint hook that can execute in GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thewtex @jhlegarreta