Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook workflow to check for CMake style #4238

Open
jhlegarreta opened this issue Oct 1, 2023 · 1 comment
Open

Add a pre-commit hook workflow to check for CMake style #4238

jhlegarreta opened this issue Oct 1, 2023 · 1 comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Comments

@jhlegarreta
Copy link
Member

Description

Add a pre-commit hook workflow to check for CMake style.

Impact analysis

Would allow reporting style inconsistencies, and by preventing a commit from being done until the style check passes, consistency in style would be ensured and readability would improve on the new code.

Expected behavior

Report locally inconsistencies in CMake code style with respect to the defined style, preventing to commit changes that do not conform to the defined style.

Actual behavior

No pre-commit hook is in place to check for CMake code style.

Versions

master.

Environment

Any.

Additional Information

Cross-referencing #4233 (comment).

@jhlegarreta jhlegarreta added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Oct 1, 2023
@thewtex
Copy link
Member

thewtex commented Oct 1, 2023

xref #4235 where we can have a pre-commit cmake-lint and cmake-format hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

No branches or pull requests

2 participants