Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in Debug mode fails after "fix-32bits-dicom-read-crash" #4546

Closed
issakomi opened this issue Mar 28, 2024 · 1 comment
Closed

Build in Debug mode fails after "fix-32bits-dicom-read-crash" #4546

issakomi opened this issue Mar 28, 2024 · 1 comment
Labels
type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Comments

@issakomi
Copy link
Member

issakomi commented Mar 28, 2024

Build in Debug mode fails after fix-32bits-dicom-read-crash .

Debian Linux 12, gcc version 12.2.0 (Debian 12.2.0-14).

/home/r/itk/ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx: In function ‘bool itk::readNoPreambleDicom(std::ifstream&)’:
/home/r/itk/ITK/Modules/Core/Common/include/itkMacro.h:504:11: error: invalid use of ‘this’ in non-member function
  504 |       if (this->GetDebug() && ::itk::Object::GetGlobalWarningDisplay())        \
      |           ^~~~
/home/r/itk/ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx:191:3: note: in expansion of macro ‘itkDebugMacro’
  191 |   itkDebugMacro(<< "No DICOM magic number found, but the file appears to be DICOM without a preamble.");
      |   ^~~~~~~~~~~~~
/home/r/itk/ITK/Modules/Core/Common/include/itkMacro.h:508:19: error: invalid use of ‘this’ in non-member function
  508 |                << this->GetNameOfClass() << " (" << this << "): " x << "\n\n"; \
      |                   ^~~~
/home/r/itk/ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx:191:3: note: in expansion of macro ‘itkDebugMacro’
  191 |   itkDebugMacro(<< "No DICOM magic number found, but the file appears to be DICOM without a preamble.");
      |   ^~~~~~~~~~~~~
/home/r/itk/ITK/Modules/Core/Common/include/itkMacro.h:508:53: error: invalid use of ‘this’ in non-member function
  508 |                << this->GetNameOfClass() << " (" << this << "): " x << "\n\n"; \
      |                                                     ^~~~
/home/r/itk/ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx:191:3: note: in expansion of macro ‘itkDebugMacro’
  191 |   itkDebugMacro(<< "No DICOM magic number found, but the file appears to be DICOM without a preamble.");
      |   ^~~~~~~~~~~~~
make[2]: *** [Modules/IO/GDCM/src/CMakeFiles/ITKIOGDCM.dir/build.make:76: Modules/IO/GDCM/src/CMakeFiles/ITKIOGDCM.dir/itkGDCMImageIO.cxx.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:9402: Modules/IO/GDCM/src/CMakeFiles/ITKIOGDCM.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

A similar error will occur with DCMTK IO if it is enabled.

@issakomi issakomi added the type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct label Mar 28, 2024
@issakomi
Copy link
Member Author

#4544 will fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

No branches or pull requests

1 participant