Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to project MONAI #126

Open
mstaring opened this issue May 11, 2021 · 4 comments
Open

Connect to project MONAI #126

mstaring opened this issue May 11, 2021 · 4 comments
Projects

Comments

@mstaring
Copy link
Collaborator

Investigate the connection with project MONAI

@mstaring mstaring added this to To Do in Roadmap via automation May 11, 2021
@Spenhouet
Copy link

Spenhouet commented Mar 23, 2022

Just to note this here. This issue is directly linked to this one (#145) since this tries to use ITKs registration via MONAI.

I currently suspect the following issues to exist:

  • Orientation
    • ITK uses LPS orientation for images and transforms
    • Monai/Nibabel uses RAS orientation for images and transforms
  • Center of Rotation
    • ITK provides the used center of rotation
    • Monai implicitly assumes the center of rotation to be the center of the image
  • World space vs. Index space.
    • All transforms and points from ITK are in world space.
    • Monai seems to operate directly on the image.
  • (0, 0, 0) Corner - ITK and Monai seem to use the opposit corner for coordinates - e.g. in a 4x4x4 image, position (0, 0, 0) in ITK is position (3, 3, 3) in Monai.

This is also tracked via this SO question: https://stackoverflow.com/questions/71529039/how-to-factor-the-itk-centerofrotationpoint-in-a-affine-transformation-matrix

@thewtex
Copy link
Member

thewtex commented Apr 5, 2022

@aylward @hjmjohnson

@aylward
Copy link
Member

aylward commented Apr 5, 2022

Here is a proposal to improve transforms in MONAI:
https://drive.google.com/file/d/1odXYUpQeoaMpjqzkeLnQK64eYRfd01YB/view

A good point of contact at MONAI is Wenqi Li wenqil@nvidia.com

@thewtex
Copy link
Member

thewtex commented Apr 29, 2022

Once Elastix has more complete itk::Transform support (in memory Python interface support via itk-elastix), this package will enable an elegant interface with MONAI: https://github.com/InsightSoftwareConsortium/itk-torch-transform-bridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
To Do
Development

No branches or pull requests

4 participants