Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake version ignored #210

Closed
dzenanz opened this issue Oct 31, 2022 · 6 comments · Fixed by #212
Closed

CMake version ignored #210

dzenanz opened this issue Oct 31, 2022 · 6 comments · Fixed by #212

Comments

@dzenanz
Copy link
Member

dzenanz commented Oct 31, 2022

Despite explicitly getting CMake 3.24 in the CI, an older version is used during some stage resulting in insufficient version error:

-- Configuring done
-- Generating done
-- Build files have been written to: /work/_cmake_test_compile/build
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.24 or higher is required.  You are running version 3.23.1


-- Configuring incomplete, errors occurred!
  File "/opt/python/cp38-cp38/lib/python3.8/site-packages/skbuild/setuptools_wrap.py", line 544, in setup
    env = cmkr.configure(cmake_args,
  File "/opt/python/cp38-cp38/lib/python3.8/site-packages/skbuild/cmaker.py", line 221, in configure
    raise SKBuildError(
An error occurred while configuring with CMake.
  Command:

    "cmake" "/work" "-G" "Ninja" "-DCMAKE_INSTALL_PREFIX:PATH=/work/_skbuild/linux-x86_64-3.8/cmake-install" "-DPYTHON_EXECUTABLE:FILEPATH=/opt/python/cp38-cp38/bin/python" "-DPYTHON_VERSION_STRING:STRING=3.8.13" "-DPYTHON_INCLUDE_DIR:PATH=/opt/_internal/cpython-3.8.13/include/python3.8" "-DPYTHON_LIBRARY:FILEPATH=libpython3.8.a" "-DSKBUILD:BOOL=TRUE" "-DCMAKE_MODULE_PATH:PATH=/opt/python/cp38-cp38/lib/python3.8/site-packages/skbuild/resources/cmake" "-DITK_DIR:PATH=/work/ITK-cp38-cp38-manylinux_2_28_x64" "-DITK_USE_SYSTEM_SWIG:BOOL=ON" "-DWRAP_ITK_INSTALL_COMPONENT_IDENTIFIER:STRING=PythonWheel" "-DSWIG_EXECUTABLE:FILEPATH=/work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/Generators/SwigInterface/swig/bin/swig" "-DCMAKE_CXX_COMPILER_TARGET:STRING=x86_64-linux-gnu" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DBUILD_TESTING:BOOL=OFF" "-DPython3_EXECUTABLE:FILEPATH=/opt/python/cp38-cp38/bin/python" "-DPython3_INCLUDE_DIR:PATH=/opt/python/cp38-cp38/bin/../include/python3.8" "-DCMAKE_BUILD_TYPE:STRING=Release"

This might be a problem in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem.

@dzenanz
Copy link
Member Author

dzenanz commented Oct 31, 2022

It looks like this will require digging to diagnose. If @jcfr or @thewtex have suggestions to steer me, it would be appreciated.

@thewtex
Copy link
Member

thewtex commented Oct 31, 2022

@dzenanz cmake is provided in the Linux Docker images via dockcross, so it may need to be bumped there.

@tbirdso
Copy link
Contributor

tbirdso commented Nov 4, 2022

@dzenanz Thanks for the fix. Was this resolved in #212?

@dzenanz
Copy link
Member Author

dzenanz commented Nov 4, 2022

No, I don't think it did. It just bumps CMake version inside dockcross.

@tbirdso
Copy link
Contributor

tbirdso commented Nov 4, 2022

Got it, I misunderstood, thanks.

@thewtex
Copy link
Member

thewtex commented Nov 24, 2022

The CMake version is not expected to come from the host system.

@thewtex thewtex closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants