Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with composer >= 2.0.9 #36

Closed
michabbb opened this issue Mar 7, 2021 · 8 comments
Closed

problem with composer >= 2.0.9 #36

michabbb opened this issue Mar 7, 2021 · 8 comments

Comments

@michabbb
Copy link

michabbb commented Mar 7, 2021

hi there,

my apologies in case I am totally wrong here.
i am using this package with version with "^1.3" inside my composer.json with PHP 5.6.9 as fixed PHP version. (yeah i know, super old).
i was wondering, why composer now takes minutes instead of seconds when just using composer with -h - so with nothing.
turned out, that this package uses nesbot/carbon (>=1.22) and this package requires kylekatarnls/update-helper (^1.1).
and the helper is scanning all my files, while composer <= 2.0.8 is not.

i don´t know what really causes that behavior, but in case it has something to do with this package i wanted to let you know.

thanks !

composer/composer#9760

@Insolita
Copy link
Owner

Insolita commented Mar 7, 2021

Unfortunately, the problem still not clear to me. Which scanner config you use? Are you install scanner globally, with composer global require? What is slow - composer work, or scanner work?
Are you sure that you use this util and not a composer plugin https://github.com/composer-unused/composer-unused ?

@michabbb
Copy link
Author

michabbb commented Mar 7, 2021

the problem exists not because of this project, i am not even using this scanner. i just wanted to let you know, that your project uses a project that uses a project that behaves differently based on the composer version, that´s all. as said, if this don´t bother you, it´s absolutely fine, i just wanted to let you know where the plugin - in my special case - is coming from ;)

@Insolita
Copy link
Owner

Insolita commented Mar 7, 2021

Ah, I understand, thanks

@michabbb
Copy link
Author

michabbb commented Mar 7, 2021

to be clear: your package IS installed in my project, but i didn´t use the scanner since a long time. but because this special plugin made me nuts... i was looking inside the dependency tree, where this plugin is coming from. and the result u see in my first posting ;)

@michabbb
Copy link
Author

michabbb commented Mar 7, 2021

it looks like the "update helper" is removed inside carbon since version 1.4.0.
in 1.39.1 it´s there.

@Seldaek
Copy link

Seldaek commented Mar 9, 2021

@michabbb IMO this should be reported to https://github.com/kylekatarnls/update-helper - as it seems to do something which misbehaves with Composer 2.0.9+. I have no idea what they are doing in that project but if the project author figures out the issue I'm happy to help out from the Composer side of things. Feel free to cc me on the issue if you create one.

@Insolita IMO this can be closed and I don't think you necessarily need to remove Carbon, but maybe you should allow carbon 2.x usage so at least people on modern PHP versions do not get stuck with this update helper dependency. I guess for @michabbb it wouldn't help if using PHP 5.6 is a requirement.

@Insolita
Copy link
Owner

Insolita commented Mar 9, 2021

@michabbb IMO this should be reported to https://github.com/kylekatarnls/update-helper - as it seems to do something which misbehaves with Composer 2.0.9+. I have no idea what they are doing in that project but if the project author figures out the issue I'm happy to help out from the Composer side of things. Feel free to cc me on the issue if you create one.

@Insolita IMO this can be closed and I don't think you necessarily need to remove Carbon, but maybe you should allow carbon 2.x usage so at least people on modern PHP versions do not get stuck with this update helper dependency. I guess for @michabbb it wouldn't help if using PHP 5.6 is a requirement.

Honestly, Carbon dependency is not so necessary, native Datetime will be enough

@Seldaek
Copy link

Seldaek commented Mar 9, 2021

Yeah if you can get rid of it that's fine too of course, but that won't fix the root cause in the update-helper project (which is installed a lot probably due to all Carbon 1.x users).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants