Instabug overrides default RxJava error handler

[linean]

Instabug automatically overrides RxJava error handler by calling RxJavaPlugins.setErrorHandler() in initialization. Because of that OnErrorNotImplementedException is not throwed anymore and there are no logs in console.

Steps to Reproduce the Problem

Run this code anywhere in the app:
Completable.fromAction(()-> { throw new RuntimeException(); }).subscribe();

Expected Behavior

App should throw:

io.reactivex.exceptions.OnErrorNotImplementedException

Actual Behavior

Nothing happens - no logs in console

Instabug integration code

Instabug.Builder(application, "my_token") .setInvocationEvents(InstabugInvocationEvent.TWO_FINGER_SWIPE_LEFT, InstabugInvocationEvent.SHAKE) .setReproStepsState(State.ENABLED) .setViewHierarchyState(Feature.State.ENABLED) .build()

SDK Version

8.0.7

Android Version

Any

Device Model

Any

[Optional] Project That Reproduces the Issue

[Korazy]

Hey @linean

Thanks for reaching out. We will look into this and get back to you as soon as possible.

[jdamcd]

I'm also seeing this in 8.0.9. The Instabug error handler set on RxJavaPlugins is not forwarding exceptions to the thread's uncaught exception handler, so exceptions thrown in e.g. onSuccess() callbacks are swallowed silently when they should terminate the app.

[Korazy]

Hey all,

Can you try to add a CompletableObserver() for the subscription you made and you should be getting the error in onError callback, like this:

Completable.fromAction(new Action() {
         @Override
         public void run() throws Exception {
             throw new IllegalAccessException("Throwable String");
         }

     }).subscribe(new CompletableObserver() {
         @Override
         public void onSubscribe(Disposable d) { }

         @Override
         public void onComplete() { }

         @Override
         public void onError(Throwable e) {
              // Get the throwable here 
         }
     });

[ablenesi]

We have the same issue on 8.0.9. Just spent a couple hours on figuring out why all our network call subscriptions are never reached.
java.lang.NoSuchMethodError: No virtual method setHeaders(Ljava/lang/String;)V in class Lcom/instabug/library/model/NetworkLog; or its super classes (declaration of 'com.instabug.library.model.NetworkLog' appears in /data/app/com.***.debug-GLEsaFJhkPv89M_FxiUEuA==/base.apk!classes5.dex)
This issue might be related to #123

[linean]

@Korazy it works like this. But this is expected, because observer handles error by itself, and RxJavaPlugins.onError is not called.

[jdamcd]

As a workaround, it's possible to clear the error handler after initialising Instabug: RxJavaPlugins.setErrorHandler(null). Surprised to see this being set, especially since we're not using the crash reporting feature.

[linean]

And even better is to first get current handler :)

val errorHandler = RxJavaPlugins.getErrorHandler()
initializeInstabug()
RxJavaPlugins.setErrorHandler(errorHandler)

[Korazy]

We currently have a fix that's pending review and testing at the moment. I will make sure to update you soon :)

[Korazy]

Hey all, can you please use this snapshot and let me know if it fixes the issue for you?

Snapshot version: 8.0.11.4-SNAPSHOT (must set compileSdkVersion to 28)
Instructions on adding snapshot: Add the following code

repositories {
    maven {
        // TODO add this only if interested in getting SNAPSHOT releases
        url "https://oss.sonatype.org/content/repositories/snapshots"
    }
}

[Korazy]

Hey all, did the snapshot fix the issue for you?

[jdamcd]

Hi @Korazy. We've noticed a related issue. The Instabug SDK (8.0.9) is setting a default exception handler, even though we're configuring the SDK with setCrashReportingState(Feature.State.DISABLED). This was overriding our expected error handling and masking further crashes. Is this issue also resolved in the snapshot?

[Korazy]

Hey @jdamcd

Would you be able to explain the issue further?

[linean]

@jdamcd this is exact same thing that I've described :)

[jdamcd]

Sure. We've observed an issue with Thread.setDefaultUncaughtExceptionHandler() being set in addition to RxJavaPlugins.setErrorHandler() which @linean described. It's unexpected because we're not using Instabug for crash reporting.

[ramiimagdi]

Hey all,

Apologies for taking some time on this, I just want to let you know that the issue is still being investigated, and we'll be reaching out to you as soon as we get a hand on it.

Thank you for your patience.

[Korazy]

Hey all,

While we do indeed set our handlers, we do forward the uncaught exception so that it goes to its usual follow-up and this shouldn't affect anything in this regard. We also don't really fail silently or prevent apps from crashing. Does that make sense?

[linean]

What about if someone is using custom exceptions handler, will Instabug overrides it silently? And sorry for asking, but I'm lost, what is the status of this issue?

[jdamcd]

@Korazy Here's a sample project to demonstrate that initialising the Instabug SDK alters RxJava behaviour: https://github.com/jdamcd/instabug-rx-issue

[Korazy]

Out of curiousity, did the snapshot I sent before not fix the issue for you?

[jdamcd]

It fixes the core issue since no RxJavaPlugins error handler is set. However, the SDK then crashes internally from system onLowMemory() callbacks. Reproduction steps in the sample project: jdamcd/instabug-rx-issue#1

[linean]

@Korazy 8.0.11.4-SNAPSHOT works for me :)

[Korazy]

@linean awesome!

@jdamcd we’ll look into that right away.

[Korazy]

@jdamcd would you be able to try this snapshot? 8.0.11.19-SNAPSHOT

[jdamcd]

@Korazy 8.0.11.19-SNAPSHOT resolves both issues. Thanks for your help! 🎉

[Korazy]

Awesome! Glad everything is working out now 😄

[jdamcd]

Hey @Korazy, could you update here when those fixes make it into a stable build? Looks like 8.0.12 & 8.0.13 from last week still have the issues. Thanks!

[Karambar]

Hi @Korazy ,

I encounter the same issue, could we have an update ?
Will it be available soon on the stable build ?
I added a fix on my side but I should not have to do this hack.

Thanks for your help !

[vayan]

Hello 👋

Same here, when is the next stable build with this fix? Cheers!

[jdamcd]

Any news on when this fix will be included in a stable release @Korazy?

[Axrorxoja]

I have same issue in in 8.1.2 version
java.lang.NoSuchMethodError: No virtual method setHeaders(Ljava/lang/String;)V in class Lcom/instabug/library/model/NetworkLog; or its super classes (declaration of 'com.instabug.library.model.NetworkLog' appears in /data/app/android-XXXJAfLGgWcyo1G0xvz6vg==/split_lib_slice_0_apk.apk!classes2.dex) at com.instabug.library.okhttplogger.InstabugOkhttpInterceptor.intercept(InstabugOkhttpInterceptor.java:128) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121) at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.java:212) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121) at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:200) at okhttp3.RealCall$AsyncCall.execute(RealCall.java:147) at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) at java.lang.Thread.run(Thread.java:764)

[mzelzoghbi]

Hi @Axrorxoja , Thanks for reporting this. We think that this issue is not related to the one mentioned in the thread from the beginning. Can you double check it? Also, You should be sure that you are using the latest version of instabug-with-okhttp-interceptor which is 8.1.2.

[Axrorxoja]

Hi @mzelzoghbi thank you for feedback

[mzelzoghbi]

Awesome! Glad everything is working out now 😄